Mesa (master): util: Fix memory leaks in unit test.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 11 23:22:04 UTC 2020


Module: Mesa
Branch: master
Commit: 96cfc684e63238a7aeabc8893fb04fe5f3781a66
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=96cfc684e63238a7aeabc8893fb04fe5f3781a66

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sat Aug  8 21:26:12 2020 -0700

util: Fix memory leaks in unit test.

Fix warnings reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable bt1 going out of scope leaks the storage
it points to.
leaked_storage: Variable bt2 going out of scope leaks the storage
it points to.

Fixes: d0d14f3f6481 ("util: Add unit test for stack backtrace caputure")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6246>

---

 src/util/u_debug_stack_test.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/util/u_debug_stack_test.cpp b/src/util/u_debug_stack_test.cpp
index b5f8ea4ba38..6add3e989b2 100644
--- a/src/util/u_debug_stack_test.cpp
+++ b/src/util/u_debug_stack_test.cpp
@@ -106,6 +106,9 @@ TEST(u_debug_stack_test, capture_not_overwritten)
    if (size > 0) {
       EXPECT_STRNE(bt1, bt2);
    }
+
+   free(bt1);
+   free(bt2);
 }
 
 #endif



More information about the mesa-commit mailing list