Mesa (master): aco: do not set valid_mask for POS0 exports on GFX 10.3
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Aug 13 07:28:53 UTC 2020
Module: Mesa
Branch: master
Commit: d452c04aa19e093afe47d225c2c02ba536ebf0ce
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d452c04aa19e093afe47d225c2c02ba536ebf0ce
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Aug 11 11:09:36 2020 +0200
aco: do not set valid_mask for POS0 exports on GFX 10.3
This hardware issue seems only present on GFX10.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6278>
---
src/amd/compiler/aco_instruction_selection.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index 766153498f4..4c9fe3fcd03 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -9943,10 +9943,10 @@ static bool export_vs_varying(isel_context *ctx, int slot, bool is_pos, int *nex
else
exp->operands[i] = Operand(v1);
}
- /* Navi10-14 skip POS0 exports if EXEC=0 and DONE=0, causing a hang.
+ /* GFX10 (Navi1x) skip POS0 exports if EXEC=0 and DONE=0, causing a hang.
* Setting valid_mask=1 prevents it and has no other effect.
*/
- exp->valid_mask = ctx->options->chip_class >= GFX10 && is_pos && *next_pos == 0;
+ exp->valid_mask = ctx->options->chip_class == GFX10 && is_pos && *next_pos == 0;
exp->done = false;
exp->compressed = false;
if (is_pos)
@@ -9988,7 +9988,7 @@ static void export_vs_psiz_layer_viewport(isel_context *ctx, int *next_pos)
exp->enabled_mask |= 0x4;
}
}
- exp->valid_mask = ctx->options->chip_class >= GFX10 && *next_pos == 0;
+ exp->valid_mask = ctx->options->chip_class == GFX10 && *next_pos == 0;
exp->done = false;
exp->compressed = false;
exp->dest = V_008DFC_SQ_EXP_POS + (*next_pos)++;
More information about the mesa-commit
mailing list