Mesa (master): turnip: delete a blit_image TODO that has already been resolved

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Aug 14 14:04:20 UTC 2020


Module: Mesa
Branch: master
Commit: f83e89507de69b55c8c899fb0fa52f9c9bf3ce26
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f83e89507de69b55c8c899fb0fa52f9c9bf3ce26

Author: Jonathan Marek <jonathan at marek.ca>
Date:   Thu Aug 13 13:24:24 2020 -0400

turnip: delete a blit_image TODO that has already been resolved

All the blit_image tests now pass when forcing the 3D path, so this TODO
is no longer relevant.

Signed-off-by: Jonathan Marek <jonathan at marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6304>

---

 src/freedreno/vulkan/tu_clear_blit.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/freedreno/vulkan/tu_clear_blit.c b/src/freedreno/vulkan/tu_clear_blit.c
index 4f27035df43..4082d3e21dd 100644
--- a/src/freedreno/vulkan/tu_clear_blit.c
+++ b/src/freedreno/vulkan/tu_clear_blit.c
@@ -1050,10 +1050,6 @@ tu6_blit_image(struct tu_cmd_buffer *cmd,
        filter == VK_FILTER_CUBIC_EXT)
       ops = &r3d_ops;
 
-   /* TODO: shader path fails some of blit_image.all_formats.generate_mipmaps.* tests,
-    * figure out why (should be able to pass all tests with only shader path)
-    */
-
    ops->setup(cmd, cs, dst_image->vk_format, info->dstSubresource.aspectMask,
               rotate[mirror_y][mirror_x], false, dst_image->layout[0].ubwc);
 



More information about the mesa-commit mailing list