Mesa (master): llvmpipe: blend has effects even if no colorbuffers.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Aug 31 03:35:23 UTC 2020
Module: Mesa
Branch: master
Commit: 2d6385715da3368597671046368ff4fe11c1ca8e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2d6385715da3368597671046368ff4fe11c1ca8e
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Jun 19 16:57:41 2020 +1000
llvmpipe: blend has effects even if no colorbuffers.
ARB_framebuffer_no_attachments + multisampling means blend
can have an effect even outside of colorbufs
Fixes:
dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.samples_4.alpha_opaque
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6381>
---
src/gallium/drivers/llvmpipe/lp_state_fs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c
index efb6bee2511..804ed9214c6 100644
--- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
+++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
@@ -3987,9 +3987,7 @@ make_variant_key(struct llvmpipe_context *lp,
key->occlusion_count = TRUE;
}
- if (lp->framebuffer.nr_cbufs) {
- memcpy(&key->blend, lp->blend, sizeof key->blend);
- }
+ memcpy(&key->blend, lp->blend, sizeof key->blend);
key->coverage_samples = 1;
key->min_samples = 1;
More information about the mesa-commit
mailing list