Mesa (staging/20.2): freedreno: Fix leak of u_transfer_helper.

[GitLab Mirror]

Module: Mesa
Branch: staging/20.2
Commit: bcc8db867e0c62f85015f9f386f720a2af6efc5d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bcc8db867e0c62f85015f9f386f720a2af6efc5d

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Nov 17 16:42:00 2020 -0800

freedreno: Fix leak of u_transfer_helper.

Fixes: d1465b3aeee3 ("freedreno: use u_transfer_helper")
Reviewed-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7695>
(cherry picked from commit 9cc8fc7bbc4a4d7fe4d3635be207daf2a6672662)

---

 .pick_status.json                                | 2 +-
 src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index e79468030f0..14d05faa9f8 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -283,7 +283,7 @@
         "description": "freedreno: Fix leak of u_transfer_helper.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "d1465b3aeee318a3a76a652325aa13d4a1946f37"
     },
diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
index ef542a7446e..72f968aa733 100644
--- a/src/gallium/drivers/freedreno/freedreno_screen.c
+++ b/src/gallium/drivers/freedreno/freedreno_screen.c
@@ -160,6 +160,8 @@ fd_screen_destroy(struct pipe_screen *pscreen)
 
 	simple_mtx_destroy(&screen->lock);
 
+	u_transfer_helper_destroy(pscreen->transfer_helper);
+
 	if (screen->compiler)
 		ir3_compiler_destroy(screen->compiler);