Mesa (master): radv: Don't invalidate the SCACHE for image barriers.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Dec 3 22:32:17 UTC 2020


Module: Mesa
Branch: master
Commit: 9a3aaffeb809e2bc11b828ee3ccbe66a01e9b8d6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9a3aaffeb809e2bc11b828ee3ccbe66a01e9b8d6

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sun Oct 18 01:52:52 2020 +0200

radv: Don't invalidate the SCACHE for image barriers.

Even ACO never uses the constant cache for images.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7875>

---

 src/amd/vulkan/radv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 2e5bd0a4a2c..4ccb86b8178 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -3321,7 +3321,7 @@ radv_dst_access_flush(struct radv_cmd_buffer *cmd_buffer,
 			flush_bits |= RADV_CMD_FLAG_INV_VCACHE;
 			/* Unlike LLVM, ACO uses SMEM for SSBOs and we have to
 			 * invalidate the scalar cache. */
-			if (!cmd_buffer->device->physical_device->use_llvm)
+			if (!cmd_buffer->device->physical_device->use_llvm && !image)
 				flush_bits |= RADV_CMD_FLAG_INV_SCACHE;
 
 			if (!image_is_coherent)



More information about the mesa-commit mailing list