Mesa (master): turnip: always emit LRZ draw state in DIRTY_DRAW_STATE path

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Dec 8 18:47:33 UTC 2020


Module: Mesa
Branch: master
Commit: af6e74bca86823be63907ec91549ff9f8e88f6fb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=af6e74bca86823be63907ec91549ff9f8e88f6fb

Author: Jonathan Marek <jonathan at marek.ca>
Date:   Wed Dec  2 23:32:13 2020 -0500

turnip: always emit LRZ draw state in DIRTY_DRAW_STATE path

The packet size is constant and assumes all states, except for the 2 input
attachment states. (this means we get an invalid packet if DIRTY_LRZ isn't
set when DIRTY_DRAW_STATE is set).

Fixes: 3c07a1499863 ("turnip: enable LRZ")

Signed-off-by: Jonathan Marek <jonathan at marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7899>

---

 src/freedreno/vulkan/tu_cmd_buffer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/freedreno/vulkan/tu_cmd_buffer.c b/src/freedreno/vulkan/tu_cmd_buffer.c
index 595a861715a..2e2713d22e5 100644
--- a/src/freedreno/vulkan/tu_cmd_buffer.c
+++ b/src/freedreno/vulkan/tu_cmd_buffer.c
@@ -3350,8 +3350,7 @@ tu6_draw_common(struct tu_cmd_buffer *cmd,
       tu_cs_emit_draw_state(cs, TU_DRAW_STATE_DESC_SETS_LOAD, pipeline->load_state);
       tu_cs_emit_draw_state(cs, TU_DRAW_STATE_VB, cmd->state.vertex_buffers);
       tu_cs_emit_draw_state(cs, TU_DRAW_STATE_VS_PARAMS, cmd->state.vs_params);
-      if (cmd->state.dirty & TU_CMD_DIRTY_LRZ)
-         tu_cs_emit_draw_state(cs, TU_DRAW_STATE_LRZ, cmd->state.lrz.state);
+      tu_cs_emit_draw_state(cs, TU_DRAW_STATE_LRZ, cmd->state.lrz.state);
 
       for (uint32_t i = 0; i < ARRAY_SIZE(cmd->state.dynamic_state); i++) {
          tu_cs_emit_draw_state(cs, TU_DRAW_STATE_DYNAMIC + i,



More information about the mesa-commit mailing list