Mesa (master): vulkan/overlay: add new options to display device/swapchain-format
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Dec 15 08:15:36 UTC 2020
Module: Mesa
Branch: master
Commit: 94687ee59f0e027f2957b7420f2ac973054b6d74
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94687ee59f0e027f2957b7420f2ac973054b6d74
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Dec 14 10:53:42 2020 +0200
vulkan/overlay: add new options to display device/swapchain-format
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3973
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8080>
---
src/vulkan/overlay-layer/overlay.cpp | 13 ++++++++-----
src/vulkan/overlay-layer/overlay_params.c | 2 ++
src/vulkan/overlay-layer/overlay_params.h | 2 ++
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/vulkan/overlay-layer/overlay.cpp b/src/vulkan/overlay-layer/overlay.cpp
index 960a5433e0a..2882bad73d4 100644
--- a/src/vulkan/overlay-layer/overlay.cpp
+++ b/src/vulkan/overlay-layer/overlay.cpp
@@ -928,11 +928,14 @@ static void compute_swapchain_display(struct swapchain_data *data)
ImGui::NewFrame();
position_layer(data);
ImGui::Begin("Mesa overlay");
- ImGui::Text("Device: %s", device_data->properties.deviceName);
+ if (instance_data->params.enabled[OVERLAY_PARAM_ENABLED_device])
+ ImGui::Text("Device: %s", device_data->properties.deviceName);
- const char *format_name = vk_Format_to_str(data->format);
- format_name = format_name ? (format_name + strlen("VK_FORMAT_")) : "unknown";
- ImGui::Text("Swapchain format: %s", format_name);
+ if (instance_data->params.enabled[OVERLAY_PARAM_ENABLED_format]) {
+ const char *format_name = vk_Format_to_str(data->format);
+ format_name = format_name ? (format_name + strlen("VK_FORMAT_")) : "unknown";
+ ImGui::Text("Swapchain format: %s", format_name);
+ }
if (instance_data->params.enabled[OVERLAY_PARAM_ENABLED_frame])
ImGui::Text("Frames: %" PRIu64, data->n_frames);
if (instance_data->params.enabled[OVERLAY_PARAM_ENABLED_fps])
@@ -1327,7 +1330,7 @@ static struct overlay_draw *render_swapchain_display(struct swapchain_data *data
if (device_data->graphic_queue->family_index != present_queue->family_index)
{
/* Transfer the image back to the present queue family
- * image layout was already changed to present by the render pass
+ * image layout was already changed to present by the render pass
*/
imb.sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER;
imb.pNext = nullptr;
diff --git a/src/vulkan/overlay-layer/overlay_params.c b/src/vulkan/overlay-layer/overlay_params.c
index afc17ec07a9..48a9f7e3b5a 100644
--- a/src/vulkan/overlay-layer/overlay_params.c
+++ b/src/vulkan/overlay-layer/overlay_params.c
@@ -165,6 +165,8 @@ parse_overlay_env(struct overlay_params *params,
/* Visible by default */
params->enabled[OVERLAY_PARAM_ENABLED_fps] = true;
params->enabled[OVERLAY_PARAM_ENABLED_frame_timing] = true;
+ params->enabled[OVERLAY_PARAM_ENABLED_device] = true;
+ params->enabled[OVERLAY_PARAM_ENABLED_format] = true;
params->fps_sampling_period = 500000; /* 500ms */
params->width = params->height = 300;
params->control = -1;
diff --git a/src/vulkan/overlay-layer/overlay_params.h b/src/vulkan/overlay-layer/overlay_params.h
index 7ff092daeff..e919f74ff6c 100644
--- a/src/vulkan/overlay-layer/overlay_params.h
+++ b/src/vulkan/overlay-layer/overlay_params.h
@@ -33,6 +33,8 @@ extern "C" {
#include <stdbool.h>
#define OVERLAY_PARAMS \
+ OVERLAY_PARAM_BOOL(device) \
+ OVERLAY_PARAM_BOOL(format) \
OVERLAY_PARAM_BOOL(fps) \
OVERLAY_PARAM_BOOL(frame) \
OVERLAY_PARAM_BOOL(frame_timing) \
More information about the mesa-commit
mailing list