Mesa (staging/20.3): radv: Don't skip layout transitions that only differ in render loop.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Dec 21 22:11:42 UTC 2020
Module: Mesa
Branch: staging/20.3
Commit: fb689963da6b9d9846d1025e2ee1225c97222284
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb689963da6b9d9846d1025e2ee1225c97222284
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Sep 20 02:23:11 2020 +0200
radv: Don't skip layout transitions that only differ in render loop.
This can result in meaningful compression changes so we shouldn't skip.
Fixes: 66131ceb8bc "radv: Pass through render loop detection to internal layout decisions."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7004>
(cherry picked from commit da36577558ee77054800cf52f04f9ada81702f89)
---
.pick_status.json | 2 +-
src/amd/vulkan/radv_cmd_buffer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index cd6a92b0e32..e5daf9d35bd 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -103,7 +103,7 @@
"description": "radv: Don't skip layout transitions that only differ in render loop.",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"master_sha": null,
"because_sha": "66131ceb8bc9f3a3e17a73d90ef520694e3b50b6"
},
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 25718e4e6d5..5555f7c4263 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -6214,7 +6214,7 @@ static void radv_handle_image_transition(struct radv_cmd_buffer *cmd_buffer,
return;
}
- if (src_layout == dst_layout)
+ if (src_layout == dst_layout && src_render_loop == dst_render_loop)
return;
unsigned src_queue_mask =
More information about the mesa-commit
mailing list