Mesa (master): turnip: Remove unsigned nonnegative check.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Dec 24 23:19:44 UTC 2020


Module: Mesa
Branch: master
Commit: 7d8d99ea129a367497512ec8df25b5995e32a2b7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d8d99ea129a367497512ec8df25b5995e32a2b7

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Thu Dec 24 13:59:36 2020 -0800

turnip: Remove unsigned nonnegative check.

index is of type uint32_t.

Fix defect reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison of
an unsigned value is always true. index >= 0U.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8231>

---

 src/freedreno/vulkan/tu_query.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/freedreno/vulkan/tu_query.c b/src/freedreno/vulkan/tu_query.c
index af8192a1956..da8330057a6 100644
--- a/src/freedreno/vulkan/tu_query.c
+++ b/src/freedreno/vulkan/tu_query.c
@@ -202,8 +202,6 @@ perfcntr_index(const struct fd_perfcntr_group *group, uint32_t group_count,
          break;
       }
       index -= group[i].num_countables;
-
-      assert(index >= 0);
    }
 
    assert(i < group_count);



More information about the mesa-commit mailing list