Mesa (staging/20.3): ci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Dec 29 00:00:21 UTC 2020


Module: Mesa
Branch: staging/20.3
Commit: b0e8fb53ba9272529e4c9de392d2e85dd8fb8172
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0e8fb53ba9272529e4c9de392d2e85dd8fb8172

Author: Eric Anholt <eric at anholt.net>
Date:   Fri Dec 18 09:48:46 2020 -0800

ci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.

When set, we want to summary-limit 0, but the meaning was inverted.  Sigh,
coding in bash.

Fixes: bf29daa1b5a3 ("ci/deqp: Switch to a new dEQP runner written in Rust.")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8164>
(cherry picked from commit 174070942b8215b3b3d7295c1ae724f277569b1f)

---

 .gitlab-ci/deqp-runner.sh | 2 +-
 .pick_status.json         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci/deqp-runner.sh b/.gitlab-ci/deqp-runner.sh
index 0010550d293..5f7f254ea46 100755
--- a/.gitlab-ci/deqp-runner.sh
+++ b/.gitlab-ci/deqp-runner.sh
@@ -91,7 +91,7 @@ else
 fi
 
 # If this CI lab lacks artifacts support, print the whole list of failures/flakes.
-if [ -z "$DEQP_NO_SAVE_RESULTS" ]; then
+if [ -n "$DEQP_NO_SAVE_RESULTS" ]; then
    SUMMARY_LIMIT="--summary-limit 0"
 fi
 
diff --git a/.pick_status.json b/.pick_status.json
index 00a93ee9fac..74b4ac9f8f3 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -40,7 +40,7 @@
         "description": "ci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "bf29daa1b5a33ce2cc62b7743b4bf7220c7b8539"
     },



More information about the mesa-commit mailing list