Mesa (20.3): 44 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Dec 31 03:59:00 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3877e880ba9d75a993e3fd394b03f4d19c2e17c
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Dec 30 19:58:01 2020 -0800
Bump version for 20.3.2 release
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9d99af1560286a51eebb6cd5e5b666c23661fd1
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Dec 30 19:57:40 2020 -0800
docs: add release notes for 20.3.2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ca951d11ade592f125d4030ffc020a0c1640931
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Sat Oct 3 13:24:30 2020 +1000
glsl: default to compat shaders in compat profile
If the shader does not specify "core" or "compatibility" in shaders
above 1.40 we were defaulting these shaders to core shaders when
in a compat profile. Instead default to compat shaders.
This brings us inline with the behaviour of the binary drivers and
fixes a crash on start-up for the game Foundation.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3594
Fixes: c7e3d31b0b5f ("glsl: fix compat shaders in GLSL 1.40")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6993>
(cherry picked from commit 6c8cc9be12dc5d6c0d2386d6addb69d8f2fb5399)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8a6bf6e1032ea62082ca303446f46a47ae3604c
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Dec 14 11:48:39 2020 -0500
st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT and skip gs
the previous commit handling this forced geometry shader usage for all cases,
but this is not ideal, so instead there are now fragment shader variants for
both depth==1 and depth!=1, corresponding to the existence of gl_Layer in the
shader
Fixes: 614c77772ac ("st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT")
Acked-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8089>
(cherry picked from commit 36097fc7ef70471ecfecd428f990233276e9c45b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f892a46cc5481edc14c2e4bf3f18e20f74545123
Author: Ryan Neph <ryanneph at google.com>
Date: Wed Dec 16 01:18:09 2020 +0000
virgl: fix BGRA emulation artifacts during window resize
On some devices, window resizing results in flashes of blue- and
orange-tinted versions of the current frame until resizing is
finished.
This fix ensures that the emubgra tweak used for GLES virgl hosts
has its enabled state flag set properly during resize events.
v2: removed unrelated whitespace change
Fixes: 6f68cacf619 ("virgl: Always enable emulated BGRA and swizzling unless specifically told not to")
Signed-off-by: Ryan Neph <ryanneph at google.com>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8119>
(cherry picked from commit accc2222174a90fd24ee56ce751feb6022ecc0c7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b62bd28ec86a87e02153a1a905c5731f5b00de74
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Dec 29 20:40:45 2020 -0800
.pick_status.json: Update to 6c8cc9be12dc5d6c0d2386d6addb69d8f2fb5399
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b21d6928056388ab04fbf4fffde4469bbdaa248a
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Dec 28 16:48:48 2020 -0800
.pick_status.json: Mark 967ae12931e0dc12855de903851222b2f0607878 as denominated
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=009e2aa5460b4be30a783cee1e8f1df5369ffb29
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Oct 15 11:20:20 2020 -0400
zink: handle null ubos
for drivers that don't support robustness features (nullDescriptor)
we can just jam in the dummy buffer here and yolo
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8226>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0e8fb53ba9272529e4c9de392d2e85dd8fb8172
Author: Eric Anholt <eric at anholt.net>
Date: Fri Dec 18 09:48:46 2020 -0800
ci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.
When set, we want to summary-limit 0, but the meaning was inverted. Sigh,
coding in bash.
Fixes: bf29daa1b5a3 ("ci/deqp: Switch to a new dEQP runner written in Rust.")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8164>
(cherry picked from commit 174070942b8215b3b3d7295c1ae724f277569b1f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=373b6eba5f2bbcab67e1522ebcc6c7df62a5b295
Author: Eric Anholt <eric at anholt.net>
Date: Wed Dec 16 11:03:17 2020 -0800
mesa/st: Update FP state when textures change with an ATI_fs bound.
We may have to make a new ATI_fs variant when the texture target changes.
Fixes a regression on piglit ati_fragment_shader-render-textargets on
llvmpipe after the switch to NIR ATI_fragment_shader.
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>
(cherry picked from commit f0606cafe8330b10ad205b29267b4fba1dfbe7b2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c74888039a7407c47d383d342d39b0466cb4654
Author: Ruijing Dong <Ruijing.Dong at amd.com>
Date: Thu Dec 3 15:34:56 2020 -0500
radeon/vcn: fix hevc 10bit profile error
hevc main10 profile error fix
CC: mesa-stable
Signed-off-by: Ruijing Dong <Ruijing.Dong at amd.com>
Reviewed-by: Leo Liu <leo.liu at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8038>
(cherry picked from commit 69487c754c48f31f1e2befa7aea0c2e78e77b0df)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2fd551d4f3cef684dc0d3dc762c206ce2fcca576
Author: Eric Anholt <eric at anholt.net>
Date: Fri Dec 11 12:39:22 2020 -0800
softpipe: count CS invocations for pipeline stats queries.
Part of fixing KHR-GL33.pipeline_statistics_query_tests_ARB.
functional_compute_shader_invocations
(also requires a test bugfix:
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2694).
Fixes: e749c30cebe0 ("softpipe: add support for compute shaders. (v2)")
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8065>
(cherry picked from commit 5dd5fb1926c72c97571ddcb5f6c696766e7c9abc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc7a1ab3456f4f68f8dace12a7e7585eb626fc8f
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Dec 28 15:58:48 2020 -0800
.pick_status.json: Update to 9ef23e428bd18c412499471b4e3550a489b72c3f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b41a3c8a1d4eff2354efb148c9594829bc38b643
Author: Hyunjun Ko <zzoon at igalia.com>
Date: Thu Nov 19 01:36:13 2020 +0000
turnip: use ir3_compiler_destroy instead of ralloc_free
Fixes: c0f22c3d9406ef3 "freedreno/ir3: add ir3_compiler_destroy()"
Signed-off-by: Hyunjun Ko <zzoon at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6808>
(cherry picked from commit ec1464077bb0cfad1e0a5181a976fbb8ba8015a4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b4cbf3776a73e5687c2657da4f3d5cbc6661b409
Author: Icecream95 <ixn at disroot.org>
Date: Tue Dec 22 13:02:34 2020 +1300
panfrost: Fix panfrost_small_padded_vertex_count for 17 vertices
All odd numbers above 10 need to be rounded up to an even number, so
add one and mask off the least significant bit instead of maintaining
a list of special cases.
Fixes crashes in SuperTuxKart.
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8191>
(cherry picked from commit a250f3620c8a2ad9164ed37d04f5241c02ccb684)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e75f406f8002f90568ea137cd9cdcb647c83727
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Dec 23 10:15:49 2020 -0800
.pick_status.json: Update to a22b85ce5e825275533ca1be9fbd47667e991356
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb689963da6b9d9846d1025e2ee1225c97222284
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Sep 20 02:23:11 2020 +0200
radv: Don't skip layout transitions that only differ in render loop.
This can result in meaningful compression changes so we shouldn't skip.
Fixes: 66131ceb8bc "radv: Pass through render loop detection to internal layout decisions."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7004>
(cherry picked from commit da36577558ee77054800cf52f04f9ada81702f89)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e2789cd78eb84d59698187f8d1770720ef9a993b
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Thu Dec 10 19:18:18 2020 +0200
ir3: Allow tesselation to use all 32 varying slots
POS, PSIZE, CLIP_DIST0, and CLIP_DIST1 have their own predefined
indices, map's size should take this into account.
Fixes: 9e063b01 "ir3: Switch tess lowering to use location"
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7917>
(cherry picked from commit 22180137e9709937116f622185d027a108410236)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=633f60ee5738e4a89b838c9f52ef013204ac87de
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Mon Dec 7 15:56:03 2020 +0200
freedreno/a6xx: Fix assert which checks the count of shader outputs
The actual max count is 32 which corresponds to 128 output components.
Fixes: 2251a434 "freedreno/a6xx: Write multiple regs for SP_VS_OUT_REG and SP_VS_VPC_DST_REG"
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7917>
(cherry picked from commit 4b208fa36b484d2dbe0e7f1fc707544d3a1f17c5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eec213d2adce3c9ce04d3007b6c6fc80584f69f3
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Dec 15 13:15:29 2020 +0200
mesa: fix layered framebuffer attachment target check
Current code was making the layer target checking for depth and stencil
attachments as well while the check in spec is specified only for color.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3980
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8102>
(cherry picked from commit 296d8662dc68612c41d0e488d9b8bdf51e674b06)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=27e6dfb06a17148b651d0fe71567a93c3b718465
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Dec 21 14:08:37 2020 -0800
.pick_status.json: Update to 8db0775f4520e08b3c539f9bd2d1f567639c088c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=50b977737e656259407bb966e9063cd9e11eb2dc
Author: Eric Anholt <eric at anholt.net>
Date: Thu Dec 17 12:30:16 2020 -0800
freedreno/a6xx: Flush depth at the end of bypass rendering, too.
We apparently don't have anything else making sure that it's flushed in
between use as a render target and use as a texture source, so bypass-mode
depth texture sampling could get stale data.
Fixes consistent (as far as I could see) failures in FD_MESA_DEBUG=nogmem
on:
dEQP-GLES31.functional.texture.multisample.samples_*.use_texture_depth_2d
dEQP-GLES31.functional.stencil_texturing.render.depth24_stencil8_draw
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8146>
(cherry picked from commit e4cdbeab814bdc2b468ec2375a74fc961a423213)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d54de72aa0e8f6c0b52a235f951a032053ec53bd
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Wed Dec 16 14:31:32 2020 -0800
spirv: Remove more dead variables
SPIR-V modules can have multiple shaders (including of the same
stage), but the global variables are all declared for the whole
module. This can result in variables with same Binding but
incompatible types, so those need to be removed before we use.
Previously, a similar issue but with a narrower scope was fixed by
6775665e5ee ("spirv: Eliminate dead input/output variables after
translation.").
This patch depends on the previous patch that prevents variables used
only in pointer initializers to be considered dead.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3686
Fixes: 3a266a18 ("nir/spirv: Add support for declaring variables")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8133>
(cherry picked from commit c4c9c780b131939fa10ede84e079a90fc090e17a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a46b833725f509ce2b8c2d33ba343ffc108a2339
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Tue Dec 15 23:25:51 2020 -0800
nir: Consider pointer initializers in nir_remove_dead_variables
Between the creation of a shader (from GLSL or SPIRV frontends) and
nir_lower_variable_initializers is called, variables may refer to
other variables for initialization. Those referred variables need to
be kept alive, so consider that in the pass.
Fixes: 7acc81056f7 ("compiler/nir: Add support for variable initialization from a pointer")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8133>
(cherry picked from commit acce4ce04ec1b591b47afeda512a9b554dac14f3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d5a9377096a8f4bc16dee075228f64d948522d7e
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Dec 18 13:54:47 2020 -0800
.pick_status.json: Mark f65750d2215242b17309b5aa8845b717bb913e77 as backported
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9063a077ff59001a77cf65ed160a9be5a76a16b
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Dec 18 13:54:42 2020 -0800
.pick_status.json: Update to b9fccafed616aa2906dad3c77dca0c67af5017b8
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a5f47bc43d6c34ed76d921b9aeaae952ca6a8bd9
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Wed Dec 16 20:51:30 2020 -0800
spirv: Implement OpArrayLength for OpenGL
Uses same NIR intrinsic as glsl_to_nir. Make it an option so it is
easy later to move Vulkan drivers incrementally to use it.
Fixes piglit test spec/arb_gl_spirv/execution/ssbo/unsized-array-length.
Backported from f65750d2215 ("spirv: Implement OpArrayLength for OpenGL").
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3691
Fixes: 15e43907 ("iris: Enable ARB_gl_spirv and ARB_spirv_extensions")
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8167>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f99fc9e73e374494536101d42abdab5e45f0ab5d
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Dec 7 20:51:45 2020 +0100
zink: fix format-mapping
These formats are incorrectly mapped, and should be reversed.
Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7982>
(cherry picked from commit d788a1d6f4ef07f75eaa761ae715ec4d5c852885)
Conflicts:
src/gallium/drivers/zink/zink_format.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c00c8d8c91d8d3ca1194645e029510eace513183
Author: Eric Anholt <eric at anholt.net>
Date: Mon Dec 14 09:24:58 2020 -0800
mesa/st: Finalize the texture before BlitFramebuffer from it.
If the texture hasn't yet been validated, the current tex image contents
may have been ignored in favor of the texture's main miptree. Fixes test
failure on softpipe and intermittent failures on radeonsi in:
https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/428
Cc: mesa-stable
Tested-by: Chia-I Wu <olvaffe at gmail.com>
Reviewed-by: Chia-I Wu <olvaffe at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8091>
(cherry picked from commit f740af27964ef148de94fd389edf736bb488bfd0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8232610da2dc2289950143718560afb28980c56e
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Wed Dec 16 10:33:59 2020 +0100
nir/opt_if: split ALU from Phi more aggressively
If the only user is a trivial bcsel which in a second step
can be turned into a phi, this conversion is also worth it
even if the previous result is not undefined or constant.
Allows for some more loop unrolling or saves a few instructions.
Totals from 62 (0.04% of 139391) affected shaders (NAVI10):
SGPRs: 4976 -> 4992 (+0.32%)
VGPRs: 4408 -> 4472 (+1.45%); split: -0.45%, +1.91%
CodeSize: 453632 -> 464000 (+2.29%); split: -0.32%, +2.60%
MaxWaves: 527 -> 511 (-3.04%); split: +0.38%, -3.42%
Instrs: 84940 -> 86681 (+2.05%); split: -0.36%, +2.41%
Cycles: 11946844 -> 11783708 (-1.37%); split: -1.40%, +0.04%
VMEM: 9403 -> 10357 (+10.15%); split: +11.59%, -1.45%
SMEM: 3003 -> 3025 (+0.73%); split: +1.07%, -0.33%
VClause: 1756 -> 1997 (+13.72%); split: -0.11%, +13.84%
SClause: 2914 -> 2915 (+0.03%); split: -0.10%, +0.14%
Copies: 6426 -> 6768 (+5.32%); split: -4.14%, +9.46%
Branches: 2105 -> 2102 (-0.14%); split: -1.66%, +1.52%
PreSGPRs: 2921 -> 2909 (-0.41%); split: -0.55%, +0.14%
PreVGPRs: 4151 -> 4179 (+0.67%); split: -0.24%, +0.92%
cc: mesa-stable
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8123>
(cherry picked from commit 8513b12590cf65f77c16a59774de2d268e5de5f9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=79c2aeabebfe1320b4ec8ccf926fcb8f97ea9b24
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Dec 18 09:35:21 2020 -0800
.pick_status.json: Update to f65750d2215242b17309b5aa8845b717bb913e77
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ba1dba7acb703ac5a6a0105ed88de6c693d4e53
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Dec 17 16:52:24 2020 +0000
aco: add block to worklist in mark_block_wqm()
Since we're requiring the branch condition to be in WQM, we have to ensure
that the block is in the worklist.
Fixes Trials Fusion hang at 4K and High settings.
fossil-db (Sienna):
Totals from 216 (0.15% of 139391) affected shaders:
SGPRs: 13392 -> 13360 (-0.24%)
CodeSize: 1321184 -> 1318592 (-0.20%)
Instrs: 255310 -> 254662 (-0.25%)
Cycles: 2178360 -> 2174652 (-0.17%)
Affected fossils in fossil-db are dirt4, nier and youngblood.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3863
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8145>
(cherry picked from commit 661922f6ac9576fc2077c5d50b53ef7edf9e8a18)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=19b92b771a9a6d172114f4ae9d17705cf4d4a757
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Thu Dec 17 14:41:52 2020 +0200
tu: pCounterBuffers can be NULL in vkCmd*TransformFeedbackEXT()
According to the spec:
"pCounterBuffers is an optional array of buffer handles [...]
If pCounterBuffers is NULL, then transform feedback will start
capturing vertex data to byte offset zero in all bound transform
feedback buffers."
"If counterBufferCount is not 0, and pCounterBuffers is not NULL,
pCounterBuffers must be a valid pointer to an array [...]"
So counterBufferCount could be non-zero with pCounterBuffers
being NULL.
Fixes crash in RenderDoc when inspecting draw call with tesselation
or geometry shader present.
Fixes: 98b0d900 "turnip: rework streamout state and add missing counter buffer read/writes"
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8140>
(cherry picked from commit b34bc3db67448e54c239e933faa268e2bff63346)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=81421b7dd4ed6d20ce3bfc9a5bfc138152002c22
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Thu Dec 17 13:50:04 2020 +0200
tu: Ignore pTessellationState if there is no tesselation shaders
According to the spec:
"pTessellationState [...] is ignored if the pipeline does not
include a tessellation control shader stage and tessellation
evaluation shader stage."
Fixes crash in RenderDoc when inspecting draw call with
geometry shader but without tesselation shaders.
Fixes: eefdca2e "turnip: Parse tess state and support PATCH primtype"
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8140>
(cherry picked from commit 6aec3c9a2340474d4c8a9243b5c7732f0aeb7149)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=abfbaa8476fe3fdec1250315e97b402355795668
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Dec 17 12:01:40 2020 +0100
radv: add missing DB flush after depth/stencil resolve operations
I thought this was a bug in CTS but the Vulkan spec says:
"VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT specifies write access
to a color, resolve, or depth/stencil resolve attachment during
a render pass or via certain subpass load and store operations."
So, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT is used to synchronize
depth/stencil resolve attachments. Yes, it's counterintuitive.
This can't actually be fixed properly for now because RADV performs
the end subpass barrier *before* resolve attachments instead of after.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8138>
(cherry picked from commit 7880faccc51b68391390071c872f5fea45e41fee)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8217078f007fb2cda2d82b0b904fbf3e80b9047c
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Tue Dec 15 16:21:12 2020 +0100
aco/ra: fix phi operand renaming
In case one operand was renamed and another operand came
from an incomplete phi, it could happen, that the original
name was not restored.
This has no impact on the code, but ensures correct SSA
is maintained during RA.
Cc: mesa-stable
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8109>
(cherry picked from commit b50d3e5760ca8af775357b4176aaac5991f93cf0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=59a94717ff06a4058ce5a4e3ee0c6b3e2ae8b59a
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Tue Dec 15 19:19:22 2020 +0100
egl: fix EGL_EXT_protected_content/surface mixup
EGL_EXT_protected_surface introduces EGL_PROTECTED_CONTENT_EXT,
while EGL_EXT_protected_content is about protected context.
When I implemented EGL_EXT_protected_surface I mixed up the 2
names, so this commit fixes it.
Fixes: bd182777c8f ("egl: implement EGL_EXT_protected_surface support")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8122>
(cherry picked from commit 663e06faa62c3e1a0e9b4e9a584ef6fb832c2cf8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf1af4a6631f503627f29c7a7cd6f56eb558529e
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Dec 17 11:43:21 2020 -0800
.pick_status.json: Update to 661922f6ac9576fc2077c5d50b53ef7edf9e8a18
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=840a9a6c67bdeb110a2c1c6412c4a27670d2c3da
Author: Marek Olšák <marek.olsak at amd.com>
Date: Wed Dec 9 19:18:37 2020 -0500
radeonsi: fix small primitive culling with MSAA force-disabled and smoothing
The problem was that the shader constants were based on the framebuffer
sample count and ignored the multisample enable state and the line/polygon
smoothing state, which uses MSAA rasterization that only sets SampleMaskIn
to get the coverage for alpha-blended smoothing (the PS epilog computes
the alpha channel from SampleMaskIn and blending generates the AA results).
- This is a complete rework that adds a new state for NGG cull constants.
- It fixes the same thing for the prim discard compute shader.
- It documents how VS_STATE.SMALL_PRIM_PRECISION is encoded.
It fixes blue corruption in Unigine Heaven with MSAA and Medium details
or better.
Fixes: 7648060dc03 - radeonsi: enable NGG culling by default on gfx10.3 dGPUs
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8134>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a87e4441348cc45faea1f442294c8cac3b5a288
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Dec 11 19:37:50 2020 +0100
aco/spill: only prevent rematerializable vars from being DCE'd if they haven't been renamed
The small DCE of the spiller only removes the original instructions
of rematerialized variables in case they are unused. If a variable
has been renamed, it cannot match any original instruction anymore.
Thus, the lookup is then unnecessary and can be omitted.
No fossil-db changes.
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8055>
(cherry picked from commit ef4101d6d73614f4f41708050f963d6038f91e25)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9497e286d3b3b13f5dc9dcea1eb486f6faf95cc
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Dec 11 14:30:30 2020 +0100
aco: fix DCE of rematerializable phi operands
Otherwise, if a phi gets spilled, the operand might be considered unused.
Fixes: d48d72e98af9436babeeb3a94b312f94bc582b36 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8055>
(cherry picked from commit 0bccfd86f6e97611a3b9b4f227aa414bc3d04e02)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5636ec0acec3e2b824144305462deacbb303c031
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Dec 14 23:35:55 2020 -0500
st/mesa: set drawpixels swizzle before creating sampler view
(some) drivers need to have the swizzle set prior to create_sampler_view
being called in order to actually apply it
Fixes: d11fefa9616 ("st/mesa: optimize 4-component ubyte glDrawPixels")
Acked-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8107>
(cherry picked from commit a709d99bfd7982bcb15d2c98bea5bc8de91ea0a7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf0f7d243e0d20cb3cd7fb1a46dc32850807f4f4
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Dec 14 11:51:14 2020 +0100
zink: fix 8 bit index handling code
index_size is specified in bytes, not bits.
Fixes: f4583b40863 ("zink: move 8bit index handling out of u_primconvert path")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8081>
(cherry picked from commit ba74e1be22f646f9639e85b12c7707e96351a075)
Conflicts:
src/gallium/drivers/zink/zink_draw.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e53124546b28b55695ddf2b564575ae3894e7efd
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Dec 16 09:21:54 2020 -0800
.pick_status.json: Update to 2d78e28ba702d366becabb8e241b861e6711c76e
More information about the mesa-commit
mailing list