Mesa (staging/19.3): 28 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Feb 3 16:47:19 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1aee273e3b8acf59151c236ad367642662f6c9f9
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Fri Jan 31 13:42:19 2020 +0100
panfrost: Fix the damage box clamping logic
When the rendering are is not covering the whole FBO, and the biggest
damage rect is empty, we can have damage.max{x,y} > damage.min{x,y},
which leads to invalid reload boxes.
Fixes: 65ae86b85422 ("panfrost: Add support for KHR_partial_update()")
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3676>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3676>
(cherry picked from commit b550b7ef3b8d12f533b67b1a03159a127a3ff34a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b3c119c508a100c86abe057de8b9d39c62aa281
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 31 16:08:31 2020 -0600
anv/blorp: Use the correct size for vkCmdCopyBufferToImage
Now that we're using an uncompressed format for the buffer, we have to
scale down the dimensions we pass into BLORP when doing buffer->image
copies.
Fixes: dd92179a72 "anv: Canonicalize buffer formats for image/buffer..."
Closes: #2452
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3664>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3664>
(cherry picked from commit d7fe9af6202413aa4e6f0f53d89577ed8ea80027)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6257f10d038a31e11c4c72780272e0b6dbc0b5e8
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 30 11:34:51 2020 -0600
intel/fs: Write the address register with NoMask for MOV_INDIRECT
This fixes a hang in the following Vulkan CTS test on TGL-LP:
dEQP-VK.descriptor_indexing.storage_buffer_dynamic_in_loop
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3642>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3642>
(cherry picked from commit f93dfb509cbf9474befae9919dd8c135bbd67093)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1e23188e7b53d69e0deb315f83ef64aada152c80
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:54:49 2020 -0600
genxml: Add a new 3DSTATE_SF field on gen12
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 9da9abf8a7a605cc9b79bd4240ff715b79ac774a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=30472cca00e3da02f4b624f893e71d33cce06637
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:59:43 2020 -0600
anv,iris: Set 3DSTATE_SF::DerefBlockSize to per-poly on Gen12+
According to the BSpec, this should prevent hangs when using shaders
with large URB entries. A more precise fix can be done but it requires
re-arranging URB setup.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit e1bdb127b6875df602bd736465d597725f326621)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fc714c5ec12e4f9095fac6df053b9f7d48c3a82
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Mon Feb 3 08:32:59 2020 -0800
.pick_status.json: Update to b550b7ef3b8d12f533b67b1a03159a127a3ff34a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=212ea9260d621f3cc3478636bf9ad05febffa6c2
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Oct 16 11:32:49 2019 -0700
bin/pick-ui: Add a new maintainer script for picking patches
In the long term the goal of this script is to nearly completely
automate the process of picking stable nominations, in a well tested
way.
In the short term the goal is to provide a better, faster UI to interact
with stable nominations.
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f7ceb368f2e5294aad73625c09503fea7dcbb43
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Fri Jan 17 09:37:57 2020 +0100
radeonsi: disable display DCC
Display DCC needs https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2836
to work correctly.
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3440>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3440>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=23f23f23cbcfbd7f1e9dfbf81424ee0cbb5e058b
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Jan 22 22:37:10 2020 -0600
anv: Improve BTI change cache flushing
This commit makes two changes:
1. We set pending_pipe_bits instead of emitting PIPE_CONTROL directly
for the flush at the end of cmd_buffer_begin_subpass.
2. Because BLORP ops such as vkCmdClearAttachments may come in the
middle of a render pass, we have to also flag the need for a cache
flush after the blorp op.
Fixes: 185630c6bc97 "anv/blorp: Do the gen11 BTI flush"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3547>
(cherry picked from commit c70a786c77370bbc47f71a9f529d50116fd511da)
Conflicts:
src/intel/vulkan/genX_cmd_buffer.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6868058763c4bbbf5ade6cb878f4e39445ac63a
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Jan 2 15:36:49 2020 +0000
aco: fix target calculation when vgpr spilling introduces sgpr spilling
A shader might require vgpr spilling but not require sgpr spilling. In
that case, the spiller lowers the sgpr target by 5 which could mean sgpr
spilling is then required. Then the vgpr target has to be lowered to make
space for the linear vgprs. Previously, space wasn't make for the linear
vgprs.
Found while testing the spiller on the pipeline-db with a lowered limit
Fixes: a7ff1bb5b9a78cf57073b5e2e136daf0c85078d6
('aco: simplify calculation of target register pressure when spilling')
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3257>
(cherry picked from commit 590c26beab153fbc7c2193ce65a9a63329a80be8)
Conflicts:
src/amd/compiler/aco_spill.cpp
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9d9c92b8a608c5ca8cd84e3d459a2f63d1f83deb
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Jan 29 00:22:02 2020 -0800
i965: Use brw_batch_references in tex_busy check
If the batch references the buffer, we will have to flush the batch
immediately before mapping it, at which point it will be busy.
(This bug has existed for a long time...even going back to BLT-era...)
Fixes: 779923194c6 ("i965/tex_image: Use meta for instead of the blitter PBO TexImage and GetTexImage")
Fixes: d5d4ba9139a ("i965/tex_subimage: use meta instead of the blitter for PBO TexSubImage")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3616>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3616>
(cherry picked from commit bdba744d700717a123232cf24647f11918fc0dcd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce0bea311bac2d44e6e99fdc9c1e0bd7be7f8da1
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Jan 7 19:13:08 2020 +0000
aco: don't always add logical edges from continue_break blocks to headers
Otherwise, code like this will be broken:
loop {
if (...) {
break;
} else {
break;
}
}
The continue_or_break block doesn't have any logical predecessors but it's
a logical predecessor of the header block. This liveness error breaks the
spiller in init_live_in_vars() (under "keep variables spilled on all
incoming paths") and eventually creates garbage reloads.
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3257>
(cherry picked from commit d282a292eca05bd9f701d8509d674e4697f510ec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=56bc3836ba14014ac5fbcf2c4c2d244c62d426d8
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Jan 2 14:54:31 2020 +0000
aco: don't consider loop header blocks branch blocks in add_coupling_code
Loops without continues create header blocks with only 1 predecessor.
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3257>
(cherry picked from commit 521525fc0a3b9008e70841542ad6e3db4b1ea4d6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5f8b1162933043ba57f61d20823e1c7a9e5a655
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Thu Jan 30 10:26:54 2020 -0800
.pick_status.json: Update to f09c466732e4a5b648d7503787777c926dd93c29
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=660e887403f3bf1568ec4461a6aa8c929176d1a5
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Jan 29 09:09:59 2020 -0800
.pick_status.json: Mark 552028c013cc1d49a2b61ebe0fc3a3781a9ba826 as denominated
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40d3eeb0e34c0089b25495d114761310a5dc6e9f
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Jan 13 14:53:56 2020 +0000
aco: run p_wqm instructions in WQM
If the p_wqm ends up creating copies, these need to be in WQM. Helps (but
doesn't completely fix) artifacts in Strange Brigade. The actual issue
still exists and is harder to fix.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3273>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3273>
(cherry picked from commit 404818dd288de1b374c3b5f3589450c382bad3c4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7e405bf7cbfd2f3ff8f75d91a82d2371f70d100
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Jan 2 19:13:53 2020 +0000
aco: ensure predecessors' p_logical_end is in WQM when a p_phi is in WQM
We want any copies to be in WQM. I don't know if this fixes any real
application, but I can create a vkrunner test than reproduces the issue.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3273>
(cherry picked from commit 2d7386a2d037497656aa9c601091fc4dd6d3ced2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ac3d12717a54bc8195864aa3e35bcdc8035fe756
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Jan 29 09:08:14 2020 -0800
.pick_status.json: Update to ca6a22305b275b49fbc88b8f4cba2fefb24c2a5d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a350a802cd776be12fb0d39315fc77507902dc53
Author: Drew Davenport <ddavenport at chromium.org>
Date: Mon Jan 27 11:13:19 2020 -0700
radeonsi: Clear uninitialized variable
|view| was not initialized leading to flaky test failures in SkQP
test unitTest_ES2BlendWithNoTexture.
Fixes: 029bfa3d253 "radeonsi: add ability to bind images as image buffers"
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3592>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3592>
(cherry picked from commit 0d99ff54cc3fb1dd85044f8971f6686138a5f149)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0a3fa8bb283bd325f8523322a4f4e27a5a13c5c
Author: Brian Ho <brian at brkho.com>
Date: Sun Jan 26 19:50:42 2020 -0800
anv: Handle unavailable queries in vkCmdCopyQueryPoolResults
If VK_QUERY_RESULT_WAIT_BIT is not set, there is currently no
special handling of unavailable queries in vkCmdCopyQueryPoolResults,
and anv will write an invalid value for the query result.
This commit updates vkCmdCopyQueryPoolResults for unavailable
queries to return 0 if the VK_QUERY_RESULT_PARTIAL_BIT flag is set
and if not, skip writing altogether.
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3586>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3586>
(cherry picked from commit 815a603889b812edc94bed61a260c76c264a8b9d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d203c0add7efaca44544ffb463ef0dc73b13baab
Author: Brian Ho <brian at brkho.com>
Date: Sun Jan 26 15:12:11 2020 -0800
anv: Properly fetch partial results in vkGetQueryPoolResults
Currently, fetching the partial results (VK_QUERY_RESULT_PARTIAL_BIT)
of an unavailable occlusion query via vkGetQueryPoolResults can
return invalid values. anv returns slot.end - slot.begin, but in the
case of unavailable queries, slot.end is still at the initial value
of 0. If slot.begin is non-zero, the occlusion count underflows to
a value that is likely outside the acceptable range of the partial
result.
This commit fixes vkGetQueryPoolResults by always returning 0 if the
query is unavailable and the VK_QUERY_RESULT_PARTIAL_BIT is set.
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3586>
(cherry picked from commit af92ce50a7e56d313f5623136d3f09e7c76475fa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f585257cb0367fccd42a544a149b793be4b03210
Author: Vasily Khoruzhick <anarsoul at gmail.com>
Date: Sat Jan 25 11:40:37 2020 -0800
lima: ppir: don't delete root ld_tex nodes without successors in current block
We don't clone ld_tex nodes into each block anymore, so ld_tex may have
successors in another block.
Fixes: c8554f849e41 ("lima/ppir: don't clone texture loads")
Reviewed-by: Erico Nunes <nunes.erico at gmail.com>
Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3564>
(cherry picked from commit 4a0f62f1fcab5350d6173c843fd95089953431a0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9250fb9f0e4f14aeb86c54eeea20dab5d43ee4ea
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Jan 22 14:26:24 2020 -0600
anv: Insert holes for non-existant XFB varyings
Thanks to optimizations, it's possible for varyings to get deleted but
still leave the variable there for nir_gather_xfb_info to find. If we
get into this case, insert a hole.
Fixes: 36ee2fd61c8 "anv: Implement the basic form of..."
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3520>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3520>
(cherry picked from commit 993f866d2e31c06462b49d760debf64d14e54a68)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ab4ab0b2735fe38a61a71aff1f54352016e49e9
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Jan 27 15:17:25 2020 +0100
radv: do not allow sparse resources with multi-planar formats
It's unsupported.
Fixes some fails or hangs with
dEQP-VK.sparse_resources.image_sparse_binding.*
Cc: 19.3 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3581>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3581>
(cherry picked from commit 83e1fa87a7e25b8e60f0817b09df8b54cfc38abd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7bcec9a6c433b12f2a1933955e292313b693760
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Jan 23 19:34:06 2020 +0000
aco: fix operand to scc when selecting SGPR ufind_msb/ifind_msb
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa78 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3541>
(cherry picked from commit 92970adb4ba4e64422f46893642f8b85f4e130f5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3b73643cac771a3edffd3afbbe32c70def44aa9
Author: Florian Will <florian.will at gmail.com>
Date: Mon Jan 27 10:30:21 2020 +0100
radv/winsys: set IB flags prior to submit in the sysmem path
This fixes missing scene objects in ZUSI 3 + dxvk. Index / vertex buffer
upload using thousands of CopyBuffer commands in one huge Vulkan command
buffer, mixed with lots of render pass begin/end and draw calls, failed
for some of the buffers.
radv divides the huge command buffer into 3 IBs, and they had random
flags set because the field was uninitialized. Maybe IBs got discarded
if they had the PREAMBLE bit set.
Signed-off-by: Florian Will <florian.will at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Cc: <mesa-stable at lists.freedesktop.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3577>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3577>
(cherry picked from commit 951083768b351b0700bdcc02758670e505cce974)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e88a9cc1c07d16d0572f103912777b441489ed34
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Jan 24 15:34:36 2020 +0200
isl: drop CCS row pitch requirement for linear surfaces
We were applying row pitch constraint of CCS surfaces to linear
surfaces. But CCS is only supported in linear tiling under some
condition (more on that in the following commit). So let's drop that
requirement for now.
Fixes a bunch of crucible assert where the byte size of a linear image
is expected to be similar to the byte size of buffer for the same
extent in the following category :
func.miptree.r8g8b8a8-unorm.aspect-color.view-2d.*download-copy-with-draw.*
v2: Move restriction to isl_calc_tiled_min_row_pitch()
v3: Move restrinction to isl_calc_row_pitch_alignment() (Jason)
v4: Update message (Lionel)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 07e16221d975 ("isl: Round up some pitches to 512B for Gen12's CCS")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3551>
(cherry picked from commit a3f6db2c4e927be7e7d40cbc39c8664030d2af59)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=37c25ea299920d7572d2f758c205bd1e516ca0a2
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Tue Jan 28 15:29:25 2020 -0800
.pick_status.json: Update to 997040e4b8353fe9b71a5e9fde2f933eae09c7a3
More information about the mesa-commit
mailing list