Mesa (master): etnaviv: Destroy rsc->pending_ctx set in etna_resource_destroy()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Feb 4 06:47:04 UTC 2020


Module: Mesa
Branch: master
Commit: c32bd325e7688c781b7e5de58a2d0534c82f00a0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c32bd325e7688c781b7e5de58a2d0534c82f00a0

Author: Marek Vasut <marex at denx.de>
Date:   Thu Jan 30 01:40:31 2020 +0100

etnaviv: Destroy rsc->pending_ctx set in etna_resource_destroy()

Destroy rsc->pending_ctx set in etna_resource_destroy(), otherwise
the memory is allocated, never free'd, and becomes unreachable. This
fixes a memory leak.

Fixes: 9e672e4d20fb ("etnaviv: keep references to pending resources")
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Marek Vasut <marex at denx.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3633>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3633>

---

 src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnaviv/etnaviv_resource.c
index 03b3ef8719e..4a992b5f668 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_resource.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_resource.c
@@ -464,6 +464,7 @@ etna_resource_destroy(struct pipe_screen *pscreen, struct pipe_resource *prsc)
    struct etna_resource *rsc = etna_resource(prsc);
 
    assert(!_mesa_set_next_entry(rsc->pending_ctx, NULL));
+   _mesa_set_destroy(rsc->pending_ctx, NULL);
 
    if (rsc->bo)
       etna_bo_del(rsc->bo);



More information about the mesa-commit mailing list