Mesa (master): gallium/osmesa: Fix MakeCurrent of non-8888 contexts.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Feb 4 18:07:07 UTC 2020


Module: Mesa
Branch: master
Commit: 0a53918f025af606450ddb9df3d032191a82ce89
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a53918f025af606450ddb9df3d032191a82ce89

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Jan 14 16:35:21 2020 -0800

gallium/osmesa: Fix MakeCurrent of non-8888 contexts.

OSMesa is weird and you only get the type (byte/ubyte/565/etc.) at
MakeCurrent time, having only a channel order at CreateContext time.  The
code was setting up a visual at CreateContext time, and then at
MakeCurrent it would fail to validate against the visual.

Reviewed-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>

---

 src/gallium/state_trackers/osmesa/osmesa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/osmesa/osmesa.c b/src/gallium/state_trackers/osmesa/osmesa.c
index f9be566eb76..b1890a33c46 100644
--- a/src/gallium/state_trackers/osmesa/osmesa.c
+++ b/src/gallium/state_trackers/osmesa/osmesa.c
@@ -697,7 +697,7 @@ OSMesaCreateContextAttribs(const int *attribList, OSMesaContext sharelist)
    attribs.options.force_glsl_version = 0;
 
    osmesa_init_st_visual(&attribs.visual,
-                         PIPE_FORMAT_R8G8B8A8_UNORM,
+                         PIPE_FORMAT_NONE,
                          osmesa->depth_stencil_format,
                          osmesa->accum_format);
 



More information about the mesa-commit mailing list