Mesa (20.0): 41 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Feb 7 16:42:06 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8dede1745c69b6b9e705808ba061fa932665c188
Author: Krzysztof Raszkowski <krzysztof.raszkowski at intel.com>
Date: Mon Feb 3 16:07:01 2020 +0100
gallium/swr: Fix gcc 4.8.5 compile error
Stop using C++14 feature so it can be compile on default centos7
gcc compiler.
Reviewed-by: Jan Zielinski <jan.zielinski at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3679>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3679>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=222b47c6c569375ad90f6192d8a993cd081fcd69
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Jan 22 16:23:14 2020 -0800
intel/fs: Don't count integer instructions as being possibly coissue
Integer instructions don't coissue. Before e64be391dd0
("intel/compiler: generalize the combine constants pass"), this pass
only looked at float sources. There's no shader-db data in that commit,
so I collected some. The results are not good:
Haswell
total instructions in shared programs: 11898805 -> 11908127 (0.08%)
instructions in affected programs: 1218680 -> 1228002 (0.76%)
helped: 2
HURT: 5171
helped stats (abs) min: 12 max: 111 x̄: 61.50 x̃: 61
helped stats (rel) min: 1.59% max: 9.20% x̄: 5.40% x̃: 5.40%
HURT stats (abs) min: 1 max: 311 x̄: 1.83 x̃: 1
HURT stats (rel) min: 0.02% max: 9.91% x̄: 1.05% x̃: 0.70%
95% mean confidence interval for instructions value: 1.55 2.05
95% mean confidence interval for instructions %-change: 1.02% 1.08%
Instructions are HURT.
total cycles in shared programs: 221664974 -> 221404750 (-0.12%)
cycles in affected programs: 120012620 -> 119752396 (-0.22%)
helped: 3464
HURT: 3159
helped stats (abs) min: 1 max: 428160 x̄: 314.55 x̃: 16
helped stats (rel) min: <.01% max: 57.33% x̄: 3.40% x̃: 1.28%
HURT stats (abs) min: 1 max: 87846 x̄: 262.54 x̃: 14
HURT stats (rel) min: <.01% max: 85.57% x̄: 3.01% x̃: 0.77%
95% mean confidence interval for cycles value: -224.23 145.65
95% mean confidence interval for cycles %-change: -0.50% -0.19%
Inconclusive result (value mean confidence interval includes 0).
total spills in shared programs: 9804 -> 10047 (2.48%)
spills in affected programs: 6869 -> 7112 (3.54%)
helped: 2
HURT: 41
total fills in shared programs: 19863 -> 20319 (2.30%)
fills in affected programs: 17428 -> 17884 (2.62%)
helped: 2
HURT: 41
LOST: 20
GAINED: 13
This also prevents regressions in "intel/fs: Promote integer constants
after lowering integer multiplication" (note: that patch will probably
not be committed). When the passes are reorderd, code like
mul(8) acc0<1>D g9<8,8,1>D -2078209981D { align1 1Q };
gets turned into
mov(1) g23<1>D 2078209981D { align1 WE_all 1N };
...
mul(8) acc0<1>D g13<8,8,1>D -g23<0,1,0>D { align1 1Q compacted };
It's not 100% clear why, but these produce different results. Note that
-2078209981 & 0x0ffff = 0x0843, and -(2078209981 & 0x0ffff) =
0xffff0843. It seems like the upper 16-bits of the negation should be
ignored.
Fixes: e64be391dd0 ("intel/compiler: generalize the combine constants pass")
Cc: Iago Toral Quiroga <itoral at igalia.com>
Suggested-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
The shaders with spills or fills hurt are the usual suspects. A couple
compute shaders in Dirt Showdown and a compute shader in Bioshock
Infinite. On Haswell, a compute shader (that appears twice in
shader-db) from Aztec Ruins was also hurt for spill and fills.
Haswell
total instructions in shared programs: 11573934 -> 11568335 (-0.05%)
instructions in affected programs: 828623 -> 823024 (-0.68%)
helped: 2825
HURT: 6
helped stats (abs) min: 1 max: 134 x̄: 2.16 x̃: 1
helped stats (rel) min: 0.02% max: 9.05% x̄: 0.84% x̃: 0.61%
HURT stats (abs) min: 1 max: 216 x̄: 81.83 x̃: 56
HURT stats (rel) min: 0.16% max: 8.65% x̄: 4.21% x̃: 4.68%
95% mean confidence interval for instructions value: -2.31 -1.64
95% mean confidence interval for instructions %-change: -0.85% -0.80%
Instructions are helped.
total cycles in shared programs: 187573593 -> 187004633 (-0.30%)
cycles in affected programs: 82816107 -> 82247147 (-0.69%)
helped: 2186
HURT: 1741
helped stats (abs) min: 1 max: 35230 x̄: 326.96 x̃: 16
helped stats (rel) min: <.01% max: 46.11% x̄: 3.11% x̃: 0.90%
HURT stats (abs) min: 1 max: 6138 x̄: 83.73 x̃: 16
HURT stats (rel) min: <.01% max: 104.11% x̄: 2.73% x̃: 0.75%
95% mean confidence interval for cycles value: -197.13 -92.64
95% mean confidence interval for cycles %-change: -0.72% -0.33%
Cycles are helped.
total spills in shared programs: 7870 -> 7743 (-1.61%)
spills in affected programs: 2260 -> 2133 (-5.62%)
helped: 31
HURT: 5
total fills in shared programs: 6320 -> 6263 (-0.90%)
fills in affected programs: 3547 -> 3490 (-1.61%)
helped: 31
HURT: 6
LOST: 9
GAINED: 9
Ivybridge
total instructions in shared programs: 11863372 -> 11859793 (-0.03%)
instructions in affected programs: 757183 -> 753604 (-0.47%)
helped: 2236
HURT: 3
helped stats (abs) min: 1 max: 81 x̄: 1.86 x̃: 1
helped stats (rel) min: 0.03% max: 5.26% x̄: 0.74% x̃: 0.48%
HURT stats (abs) min: 11 max: 301 x̄: 192.33 x̃: 265
HURT stats (rel) min: 1.55% max: 10.51% x̄: 6.89% x̃: 8.62%
95% mean confidence interval for instructions value: -2.01 -1.18
95% mean confidence interval for instructions %-change: -0.77% -0.70%
Instructions are helped.
total cycles in shared programs: 178377378 -> 177946087 (-0.24%)
cycles in affected programs: 76261390 -> 75830099 (-0.57%)
helped: 1635
HURT: 1395
helped stats (abs) min: 1 max: 34796 x̄: 333.53 x̃: 16
helped stats (rel) min: <.01% max: 47.15% x̄: 2.82% x̃: 0.64%
HURT stats (abs) min: 1 max: 4315 x̄: 81.74 x̃: 18
HURT stats (rel) min: <.01% max: 49.98% x̄: 1.99% x̃: 0.53%
95% mean confidence interval for cycles value: -197.06 -87.62
95% mean confidence interval for cycles %-change: -0.78% -0.43%
Cycles are helped.
total spills in shared programs: 4188 -> 4182 (-0.14%)
spills in affected programs: 1557 -> 1551 (-0.39%)
helped: 30
HURT: 3
total fills in shared programs: 5056 -> 5245 (3.74%)
fills in affected programs: 2708 -> 2897 (6.98%)
helped: 30
HURT: 3
LOST: 5
GAINED: 1
No shader-db changes on any other Intel platform.
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3544>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3544>
(cherry picked from commit 59488cbbaca1268841fe5ba42d0a1202b33be23b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ccf70209d2880e53203e792a565b48943ec284e0
Author: Eric Engestrom <eric at engestrom.ch>
Date: Sun Feb 2 17:15:09 2020 +0000
util/disk_cache: check for write() failure in the zstd path
CoverityID: 1458074
Fixes: a8d941091f72923561a6 ("util: Use ZSTD for shader cache if possible")
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3672>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3672>
(cherry picked from commit 2799676218249c5b9f1dc0a6367e459a1ad5642e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7538851a2277e45dfda871c1df50b5424f46ebce
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Jan 15 14:07:29 2020 +0200
anv: implement gen9 post sync pipe control workaround
We've been missing this workaround for a while and since it's required
for Gen12, let's implement it for Gen9 first.
v2: Update comment for Gen9.
v3: Fix clearing of bits... (Lionel)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3405>
(cherry picked from commit 8949d27bb8b4385e92049c18f728bdcf0a79b093)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c937b846437723bf4ead3447bef716aa1d252816
Author: Rob Clark <robdclark at chromium.org>
Date: Tue Feb 4 13:46:56 2020 -0800
freedreno: allow ctx->batch to be NULL
This was mostly true already, now that we use `fd_context_batch()` for
first access to batch in draw/clear/grid paths. So we can drop the old
code in `batch_flush()` that tried to prevent `ctx->batch` from being
NULL.
Fixes a crash with a large number of tabs in chromium.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Signed-off-by: Rob Clark <robdclark at chromium.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3700>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3700>
(cherry picked from commit 2c07e03b792d57ae807a6953f0d8ff5f4bcdffd0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8b9233d5a48a3feff41d878e7fcdbd639c872c5
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Thu Jan 30 17:58:55 2020 +0100
radv: Do not set SX DISABLE bits for RB+ with unused surfaces.
The extra bits in CB_SHADER_MASK break dual source blending in
SkQP on a Stoney device. However:
- As far as I can tell, some other dual source blend tests are passing
before and after the change.
- A hacked around skqp passes on my Vega desktop and Raven laptop
- Getting Skqp to give any useful info or to run it outside of Android
on ChromeOS is proving difficult.
I have confirmed 3 strategies that seem to work:
- The old radv behavior of setting CB_SHADER_MASK to 0xF
- AMDVLK: CB_SHADER_MASK = 0xFF, and the 3 RB+ regs
are 0.
- radeonsi: CB_SHADER_MASK = 0xFF, but does not set DISABLE
bits in SX_BLEND_OPT_CONTROL for CB 1-7.
Let us use the radeonsi solution as that solution also seems like the correct
thing to do for holes. I have tested on my Raven laptop that setting the high
surfaces to not disabled and downconvert to 32_R does not imply a performance
penalty.
Fixes: e9316fdfd48 "radv: fix setting CB_SHADER_MASK for dual source blending"
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3670>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3670>
(cherry picked from commit 65a6dc5139fddd5e01eaedcc57fc67e0a6a28c94)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e163a399942a929bcf1b9f3c53f6750e2fcf270b
Author: Eric Engestrom <eric at engestrom.ch>
Date: Sun Feb 2 17:04:29 2020 +0000
freedreno/perfcntrs: fix fd leak
CoverityID: 1110568, 1458071
Fixes: 5a13507164a26fc796f0 ("freedreno/perfcntrs: add fdperf")
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3671>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3671>
(cherry picked from commit cae609326678bd00702261f756ce0c16efd530d4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce7f0212692c8423c2a7b0f564e0661d247b4939
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Fri Dec 27 15:12:24 2019 +0200
st/mesa: Handle the rest renderbuffer formats from OSMesa
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2189
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/989
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2036
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3216>
(cherry picked from commit d83abf1d378be059b4f41a6a44a9bf24c7394084)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=26adf4b5326ce3188e9133af17eb63386c1c8a84
Author: Eric Engestrom <eric at engestrom.ch>
Date: Tue Feb 4 16:23:59 2020 +0000
util/os_socket: fix header unavailable on windows
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2464
Fixes: e62c3cf350a8b169e640 ("util/os_socket: Include unistd.h to fix build error")
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Krzysztof Raszkowski <krzysztof.raszkowski at intel.com>
(cherry picked from commit d1165ad18b5e1d8b137daff1b1ad3d11ba4445e4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=27e39daa4b5ca522f1a4f4d3c6cd939ba053cdc6
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Wed Jan 29 14:34:50 2020 +0200
i965: Do not set front_buffer_dirty if there is no front buffer
Otherwise there will be a warning:
"libEGL warning: FIXME: egl/x11 doesn't support front buffer rendering."
Happens with EGL_KHR_surfaceless_context:
eglMakeCurrent(egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, egl_context)
eglMakeCurrent(egl_display, egl_surface, egl_surface, egl_context)
glFlush() // Here will be a warning
Cc: <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1525
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3628>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3628>
(cherry picked from commit 36126b6211f1ac2da0aa94411608b2320553dbb6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=69604c6fd42d13d6c077cded4add5cc6c9273fe1
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Feb 5 08:58:35 2020 -0800
.pick_status.json: Update to 7eaf21cb6f67adbe0e79b80b4feb8c816a98a720
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=450657e26c15aaa6c5732c3374916d5c4c179e52
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Feb 3 18:22:31 2020 +0100
st/mesa: use uint-result for sampling stencil buffers
Otherwise, we end up mismatching the result-type and the sampler-type.
Fixes: 642125edd97 ("st/mesa: use uint-samplers for sampling stencil buffers")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3680>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3680>
(cherry picked from commit fd27fb511386615cd6b44b037f9f5117846b51d4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ecf9055e9c3b4b151f13e49833e6a530e24ea126
Author: Marek Vasut <marex at denx.de>
Date: Thu Jan 30 01:40:31 2020 +0100
etnaviv: Destroy rsc->pending_ctx set in etna_resource_destroy()
Destroy rsc->pending_ctx set in etna_resource_destroy(), otherwise
the memory is allocated, never free'd, and becomes unreachable. This
fixes a memory leak.
Fixes: 9e672e4d20fb ("etnaviv: keep references to pending resources")
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Marek Vasut <marex at denx.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3633>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3633>
(cherry picked from commit c32bd325e7688c781b7e5de58a2d0534c82f00a0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=66bb55cc68519f4c3a99b2be79b7ab1000dc2b81
Author: Jan Vesely <jan.vesely at rutgers.edu>
Date: Thu Jan 30 01:23:54 2020 -0500
clover: Use explicit conversion from llvm::StringRef to std::string
Fixes build after llvm 777180a32b61070a10dd330b4f038bf24e916af1
("[ADT] Make StringRef's std::string conversion operator explicit")
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
(cherry picked from commit 0ccda2ebff83816cecf4dcb48f367a0d5c8f5fb1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=958f06b99f1bb936eb1033b03f91ba4c15cc177c
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Tue Feb 4 08:10:02 2020 -0800
.pick_status.json: Update to 9afdcd64f2c96f3fcc1a28912987f2e8066aa995
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7bc056dd785cd8d3cb98feec856e90ef63f43dcd
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date: Fri Jan 31 13:42:19 2020 +0100
panfrost: Fix the damage box clamping logic
When the rendering are is not covering the whole FBO, and the biggest
damage rect is empty, we can have damage.max{x,y} > damage.min{x,y},
which leads to invalid reload boxes.
Fixes: 65ae86b85422 ("panfrost: Add support for KHR_partial_update()")
Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3676>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3676>
(cherry picked from commit b550b7ef3b8d12f533b67b1a03159a127a3ff34a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b5a345595a1be0d7fab2f03c768c84968cd40ab3
Author: Bernd Kuhls <bernd.kuhls at t-online.de>
Date: Fri Jan 31 18:48:06 2020 +0100
util/os_socket: Include unistd.h to fix build error
Fixes
In file included from ../src/util/os_socket.c:8:
../src/util/os_socket.h:26:1: error: unknown type name ‘ssize_t’; did you mean ‘size_t’?
ssize_t os_socket_recv(int socket, void *buffer, size_t length, int flags);
seen with gcc version 8.3.0 (Buildroot 2019.11) and uClibc 1.0.32.
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Fixes: ef5266ebd50e7fa65c56 ("util/os_socket: Add socket related functions.")
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3659>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3659>
(cherry picked from commit e62c3cf350a8b169e6401d5f1e1f17388cdc4b77)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0cac8f332add50892a2ca4ea408b7cec998c78a9
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 31 16:08:31 2020 -0600
anv/blorp: Use the correct size for vkCmdCopyBufferToImage
Now that we're using an uncompressed format for the buffer, we have to
scale down the dimensions we pass into BLORP when doing buffer->image
copies.
Fixes: dd92179a72 "anv: Canonicalize buffer formats for image/buffer..."
Closes: #2452
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3664>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3664>
(cherry picked from commit d7fe9af6202413aa4e6f0f53d89577ed8ea80027)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e87c0c17b245e837cf45c608410541d5ac6598df
Author: Vinson Lee <vlee at freedesktop.org>
Date: Thu Jan 30 22:19:32 2020 -0800
lima: Fix build with GCC 10.
This patch fixes this build error with GCC 10.
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_context.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_resource.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_draw.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_bo.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_submit.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_util.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
/usr/bin/ld: src/gallium/drivers/lima/liblima.a(lima_texture.c.o):src/gallium/drivers/lima/lima_util.h:32: multiple definition of `lima_dump_command_stream'; src/gallium/drivers/lima/liblima.a(lima_screen.c.o):src/gallium/drivers/lima/lima_util.h:32: first defined here
Fixes: d71cd245d744 ("lima: Rotate dump files after each finished pp frame")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Qiang Yu <yuq825 at gmail.com>
(cherry picked from commit 02658df152d1a7fedd8ce61dbe6e84566c8c75d0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e6fbf8d9d3b90bec356cdd8a91fee99b222c82fc
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 30 11:34:51 2020 -0600
intel/fs: Write the address register with NoMask for MOV_INDIRECT
This fixes a hang in the following Vulkan CTS test on TGL-LP:
dEQP-VK.descriptor_indexing.storage_buffer_dynamic_in_loop
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3642>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3642>
(cherry picked from commit f93dfb509cbf9474befae9919dd8c135bbd67093)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=208fb2edfad8b93c2e944cd0ac7a118d1c1b9635
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Jan 31 10:41:39 2020 +0100
aco: fix image_atomic_cmp_swap
Fixes: 71440ba0f5512fe455be66ca48b253ecc37478a9 ('aco: reorder VMEM operands in ACO IR')
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3652>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3652>
(cherry picked from commit 3b323d66019bcbb56811b66947b39e77a2c7c3e0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=623126e7419bea300d19314ed5ab6e75fc68e181
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Mon Feb 3 08:50:47 2020 -0800
.pick_status.json: Update to b550b7ef3b8d12f533b67b1a03159a127a3ff34a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b43bee72fc269348aea7336b6096fe906d14eaf
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Fri Jan 31 08:23:02 2020 +0100
aco: fix MUBUF VS input loads when expanding vec3 to vec4 on GFX6
When some unused channels are skipped and that we expand vec3 loads
to vec4 loads, we have to adjust the fourth component.
While we are at it, add an assertion to make sure we don't use
MUBUF for vec3 loads on GFX6.
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2450
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2442
Fixes: 6aecc316 ("aco: fix VS input loads with MUBUF on GFX6")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3641>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3641>
(cherry picked from commit 0d14f41625fa00187f690f283c1eb6a22e354a71)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e33167af7977d4d11f846e99ddee01c7a757294c
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Jan 27 13:13:20 2020 -0600
anv: Always fill out the AUX table even if CCS is disabled
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 8c5fd2942b4fb2005b3d01fb4cab86a4162c8a90)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f60209b935ae94e1d37768d2c16bbeec48010e8c
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 14:41:50 2020 -0600
iris: Plumb deref block size through to 3DSTATE_SF
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 2ccdf881aba7c8cd0c7175995e351e783e0fd11d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0aff56bd7a9eac18b55ad82857e767cfa8e21bf9
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 14:14:03 2020 -0600
anv: Plumb deref block size through to 3DSTATE_SF
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit e6b39850f092b387881c4fb4260c9465971422aa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0bacf9963b8b1387c7fff35606bdfdcadf2119b6
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 14:13:28 2020 -0600
intel/blorp: Plumb deref block size through to 3DSTATE_SF
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit ce9c45a60ed51ddb27bd969bdc61336f18121a07)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc7ff68df76541715b214c33d80802e0b20706f2
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 14:10:40 2020 -0600
intel/common: Return the block size from get_urb_config
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit fdc0c19328fd8e02e4b1bd5c62b93ce6c4597ca1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4be5ef5caab75923eab09f8d423a7cbc3507c713
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:05:10 2020 -0600
anv: Emit URB setup earlier
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit e340a79b9c4b6ee35eaa10a685395a67d0b0b440)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a57247da824a983ac232ee5df6261cafd1505b1
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 13:38:52 2020 -0600
iris: Consolodate URB emit
Now that we don't have to carry a URB state emit function for BLORP we
can roll some stuff together and drop a genX helper.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit e928676b69bf9cafce1c0304dd473c926b9f2854)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=deeba167fd2d5964e5fd6385d24999ded0d234f8
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 12:09:13 2020 -0600
intel/blorp: Always emit URB config on Gen7+
Previously, i965/iris tried to reuse the currently programmed URB config
if it was good enough for BLORP, rather than reprogramming it each time.
However, this will make some things harder on Gen12+ and we've not seen
any performance impact from emitting URB more frequently in ANV.
This makes the blorp <-> driver interface a bit simpler on Gen7+ because
now all the driver has to do is to provide the L3$ config rather than
trying to hand off URB re-config to blorp.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 09e4c33085f15ffa691053143bec9dbf4aecfeaa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9cf6b5f60a6b405d2d2dadd3e14e636403d3386
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:02:26 2020 -0600
intel: Take a gen_l3_config in gen_get_urb_config
Instead of making each driver pass in the same push constant size and do
it's own L3$ config URB size calculation, just make them pass in their
L3$ configuration.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 73a684964b392c4df84373e8419e355267d57ff5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46c731477041dc4c6db1965493c5cbc46f470647
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 13:30:48 2020 -0600
i965: Re-emit l3 state before BLORP executes
If BLORP is the first thing to execute, we may not have set the L3$
config yet. That's not normally a problem but we're about to add code
to BLORP which will look at brw_context::l3::config and we'd like that
to be initialized. It's also just good practice.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 9d05822cb8b5d3fd066c64722b76b3507a7fd24f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f1c8089f97866db1f64c09d1b1839f8d36489015
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 14:22:58 2020 -0600
iris: Use the URB size from the L3$ config
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit bff7b3c7bd56c25544ea6e3ea9452358374db10a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5d9a1303bafaf6cdef8c9fca62eceed9ccc5522f
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 11:37:31 2020 -0600
iris: Store the L3$ configs in the screen
We only calculate them based on device info and never change them so
this seems like a reasonable place to put them. We could also put them
in the context, but that's not accessible from iris_init_*_context.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 99f3178a249525d333c5b27d755a0f99a81b3c17)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8585ae7c03b1f523ac7acb582eaa4d0dd1687e28
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 11:36:52 2020 -0600
iris: Set SLMEnable based on the L3$ config
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 6471bac99ec11c7901d6fc9bda908c047e621f5f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6c705ea125714e86bba0801e7c28fe6da1675658
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 17 11:23:14 2020 -0600
intel/genxml: Drop SLMEnable from L3CNTLREG on Gen11
SML is no longer in the L3$ on Gen11+. It's not incredibly clear from
the docs but no Gen11 platforms are in the list of platforms on which
this bit exists. Also, we've been always setting it false on Gen11 in
ANV and i965 thanks to GEN_L3P_SLM being zero with no ill effects.
Cc: "20.0" mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 73434b665b2ec50cbd1060ce831aec3b2e21517c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ea7ab6945596b9d94891215ef5e8e5c58449553f
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:59:43 2020 -0600
anv,iris: Set 3DSTATE_SF::DerefBlockSize to per-poly on Gen12+
According to the BSpec, this should prevent hangs when using shaders
with large URB entries. A more precise fix can be done but it requires
re-arranging URB setup.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit e1bdb127b6875df602bd736465d597725f326621)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6c0b18c5d1d9ea676bad60399848b6bc289e31e6
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Jan 16 17:54:49 2020 -0600
genxml: Add a new 3DSTATE_SF field on gen12
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3454>
(cherry picked from commit 9da9abf8a7a605cc9b79bd4240ff715b79ac774a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=102aa6d5496c02b3e495308fd118e5b0e5d90dd2
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Fri Jan 31 08:50:23 2020 -0800
.pick_status.json: Update to 0d14f41625fa00187f690f283c1eb6a22e354a71
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b611a616c3947dd55d1530664bca4882368c14d9
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Oct 16 11:32:49 2019 -0700
bin/pick-ui: Add a new maintainer script for picking patches
In the long term the goal of this script is to nearly completely
automate the process of picking stable nominations, in a well tested
way.
In the short term the goal is to provide a better, faster UI to interact
with stable nominations.
More information about the mesa-commit
mailing list