Mesa (staging/20.0): panfrost: Remove unused anonymous enum variables.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Feb 11 17:59:18 UTC 2020
Module: Mesa
Branch: staging/20.0
Commit: 75ea9c808d27023c3d726bd2060c50594b0b30a5
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=75ea9c808d27023c3d726bd2060c50594b0b30a5
Author: Vinson Lee <vlee at freedesktop.org>
Date: Fri Feb 7 13:25:12 2020 -0800
panfrost: Remove unused anonymous enum variables.
This patch fix these build errors with GCC 10.
/usr/bin/ld: src/gallium/drivers/panfrost/libpanfrost.a(pan_resource.c.o):src/panfrost/midgard/midgard_compile.h:52: multiple definition of `pan_sysval'; src/gallium/drivers/panfrost/libpanfrost.a(pan_screen.c.o):src/panfrost/midgard/midgard_compile.h:52: first defined here
/usr/bin/ld: src/gallium/drivers/panfrost/libpanfrost.a(pan_resource.c.o):src/panfrost/midgard/midgard_compile.h:68: multiple definition of `pan_special_attributes'; src/gallium/drivers/panfrost/libpanfrost.a(pan_screen.c.o):src/panfrost/midgard/midgard_compile.h:68: first defined here
Fixes: 7e8de5a707f7 ("panfrost: Implement system values")
Fixes: 306800d747bc ("pan/midgard: Lower gl_VertexID/gl_InstanceID to attributes")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3752>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3752>
(cherry picked from commit 63345a359656246df83b416743031c1836457d23)
---
.pick_status.json | 2 +-
src/panfrost/midgard/midgard_compile.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index 2ab6cbc2497..c1de0e23976 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -58,7 +58,7 @@
"description": "panfrost: Remove unused anonymous enum variables.",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"master_sha": null,
"because_sha": "7e8de5a707f7279929d7396550024b8cdc6a8c61"
},
diff --git a/src/panfrost/midgard/midgard_compile.h b/src/panfrost/midgard/midgard_compile.h
index 51d1c3fe1c3..48873207f4e 100644
--- a/src/panfrost/midgard/midgard_compile.h
+++ b/src/panfrost/midgard/midgard_compile.h
@@ -49,7 +49,7 @@ enum {
PAN_SYSVAL_SSBO = 4,
PAN_SYSVAL_NUM_WORK_GROUPS = 5,
PAN_SYSVAL_SAMPLER = 7,
-} pan_sysval;
+};
#define PAN_TXS_SYSVAL_ID(texidx, dim, is_array) \
((texidx) | ((dim) << 7) | ((is_array) ? (1 << 9) : 0))
@@ -65,7 +65,7 @@ enum {
PAN_VERTEX_ID = 16,
PAN_INSTANCE_ID = 17,
PAN_MAX_ATTRIBUTE
-} pan_special_attributes;
+};
typedef struct {
int work_register_count;
More information about the mesa-commit
mailing list