Mesa (master): 23 new commits

Sun Feb 16 14:43:20 UTC 2020

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c4a70b64d6f916ecdf9055b52078bf4f63e7a97
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 11 21:50:04 2020 -0500

    pan/decode: Remove extraneous newline
    
    pandecode_log already does this.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ab0bf1f939af480997fafd8bf562644a60df08a
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Thu Feb 13 17:14:05 2020 -0500

    pan/midgard: Use fprintf instead of printf for constants
    
    I was wondering where those constants disappeared to :-)
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Fixes: 968f36d1fc0 ("pan/midgard: Support disassembling to a file")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6af14d3685fac433193b92f9ad6c9f8a3eaf87ff
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Thu Feb 13 17:12:51 2020 -0500

    pan/midgard: Don't crash with constants on unknown ops
    
    Just use a dummy name instead.. we can't know a priori what type an
    unknown op will consume, but we don't want to dereference a null
    pointer.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Fixes: 24360966ab3 ("panfrost/midgard: Prettify embedded constant
    prints")
    
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5c06ecd2c64a36496f7a0a1d2811d8a90b1a0620
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Thu Feb 13 07:41:38 2020 -0500

    pan/midgard: Identify stack barrier flag
    
    In case thread local storage is used.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3747fb1ebbb1c3d6f62abaf92b100f7f52d0f6b
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Wed Feb 12 08:39:29 2020 -0500

    pan/midgard: Set xyzx swizzle for load_compute_arg
    
    Probably harmless but the w component doesn't appear valid so let's
    match the blob... one less bit to be nervous about.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0ee55ad2a4e63cce88c9d68bfdf7d1c0e7e88b0
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 11 21:43:43 2020 -0500

    pan/midgard: Infer tags entirely
    
    We're so close, again marking off a few edge cases is enough to allow us
    to omit this data entirely. Woot!
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=57a84278fda2ce556905f800409658639d642962
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 11 21:37:18 2020 -0500

    pan/midgard: Imply next tags
    
    As long as we can disambiguate a few edge cases, we can imply next tags
    entirely which cleans up the disassembly a fair bit (though not as much
    as implying tags entirely would -- we'll get there!)
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=453c64663ce938952588325ba4c960bc63297582
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 11 21:20:30 2020 -0500

    pan/midgard: Overhaul tag handling
    
    We unify disparate metadata about tags into a single structure to ensure
    information is not left out.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9168e7a65deefae7bb8a40c583c205c408cbecab
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 11 15:58:18 2020 -0500

    pan/midgard: Improve barrier disassembly
    
    Just move some state from unknowns to actual keywords.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d208212f80effe4e2831fa408e976099317230b0
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 4 09:34:11 2020 -0500

    pan/midgard: Use dummy tag for empty shaders
    
    Fixes INSTR_INVALID_ENC in dEQP-GLES31.functional.compute.basic.empty
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b2cab6b6db4244cb95abb5bf13734360df8391ea
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 4 09:29:59 2020 -0500

    pan/midgard: Fix 32/64 mixed swizzle packing
    
    Occurs in SSBO address computation.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a55a2e02a54cadcd9466d02021c2c7a0739c373f
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 4 09:28:06 2020 -0500

    pan/midgard: Allow jumping out of a shader
    
    This comes up as a `return;` instruction in a compute shader. We need to
    use the special tag 1 to signify "break". Fixes numerous
    INSTR_INVALID_ENC faults in dEQP-GLES31.functional.compute.basic.*
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f59098d1a7a00d51e2b15e06aba359835c7e1ea
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 3 20:23:41 2020 -0500

    pan/midgard: Implement barriers
    
    Barriers execute on the texture pipeline on Midgard, so let's
    tentatively handle barrier() as conservatively as possible (forcing
    memory barriers of both buffers and shared memory). Implementation isn't
    quite there yet -- it doesn't look at interactions of adjacent barriers
    like it's supposed to -- but the core is there.
    
    Fixes dEQP-GLES31.functional.compute.basic.ssbo_local_barrier_single_invocation
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f0b928921dfb3ed63642ab1ce1c925fbac9f51b
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 3 19:21:59 2020 -0500

    pan/midgard: Fix swizzles harder
    
    Just for disassembly for now~
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbe1fd3de0aa7c618286ee79082f7bbcd7b8e171
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 3 15:12:24 2020 -0500

    pan/midgard: Fix missing prefixes
    
    I was wondering where those were going... :)
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Fixes: c1952779d68 ("pan/decode: Dump to a file")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=521406a069e0f918d57fc29bba85423faf316141
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 3 14:55:58 2020 -0500

    pan/midgard: Track pressure when scheduling ld/st
    
    Fixes RA failure in
    dEQP-GLES31.functional.shaders.builtin_functions.common.modf.* (which
    uses multiple indirect SSBO writes)
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9603126b74d03bc6974ea116ce4f7d80fb9573aa
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Thu Feb 6 14:29:42 2020 -0500

    panfrost: Allocate RAM backing of shared memory
    
    Unlike other GPUs, Mali does not have dedicated shared memory for
    compute workloads. Instead, we allocate shared memory (backed to RAM),
    and the general memory access functions have modes to access shared
    memory (essentially, think of these modes as adding this allocates base
    + workgroupid * stride  in harder). So let's allocate enough memory
    based on the shared_size parameter and supply it.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=50138abb5a0328b530723dfef5e9a8ac9dea2692
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 10 08:56:33 2020 -0500

    panfrost: Rename unknown2_8 to padding
    
    It's zero everywhere.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6d9ee3e65aea9262a9890fb34032ef7c693aef2d
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 10 08:51:37 2020 -0500

    panfrost: Rename bifrost_framebuffer->mali_framebuffer
    
    (And bifrost_fb_extra to mali_framebuffer_extra, bifrost_render_target
    to mali_render_target)
    
    These structures are the norm on midgard t760+, drop the bifrost names,
    it's silly... unrelated to the rest of the series but while I'm messing
    with pandecode and cleaning up bifrost abstractions, might as well.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6dc105555b43695e1de49baf946c6179987f2f4a
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Feb 10 08:47:09 2020 -0500

    panfrost: Unify bifrost_scratchpad with mali_shared_memory
    
    It looks like these are the same structure, so this allows us to reuse
    mali_shared_memory across architectures, and dispels with the
    Bifrost-specific mystery of the scratchpads... nothing so mysterious
    after all, just stack.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=254f40fd535ef57dee2bcc4afd97840749ce5918
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Wed Feb 5 15:58:28 2020 -0500

    panfrost: Identify mali_shared_memory structure
    
    This small structure is used to configure shared memory and stack for
    compute shaders, and is also present at the beginning of framebuffer
    descriptors. Let's factor it out.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=418ca5dc1ac01045818ad3222d2e0bc51dc2e904
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 4 14:24:44 2020 -0500

    panfrost: Ensure compute shader_meta is zeroed
    
    In theory the hardware doesn't care but it'll make for easier traces.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=058faf5a4bd448e1c188042ea017f8fbfd565b9e
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Feb 4 14:15:27 2020 -0500

    panfrost: Update comment about magic number relating to barriers
    
    It's a complicated story. But from what I can tell, in GL compute
    without barriers, the blob is able to redistribute the workgroups in
    various ways (that are not yet understood), whereas with barriers it
    cannot redistribute anything, which accounts for erratic workgroup
    packing without barriers.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3835>