Mesa (master): llvmpipe: Fix real uninitialized use of "atype" for SEMANTIC_FACE

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Feb 19 00:13:35 UTC 2020


Module: Mesa
Branch: master
Commit: 45b2ccc6b30c9e4c3382e6b462a2f5357c15d3b8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=45b2ccc6b30c9e4c3382e6b462a2f5357c15d3b8

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Jan 28 13:14:47 2020 -0800

llvmpipe: Fix real uninitialized use of "atype" for SEMANTIC_FACE

Fixes: 502548a09c5a ("gallivm/llvmpipe: add support for front facing in sysval.")
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3867>

---

 src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index 913fcb2a914..38e92cb67d3 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
@@ -1548,6 +1548,7 @@ emit_fetch_system_value(
 
    case TGSI_SEMANTIC_FACE:
       res = lp_build_broadcast_scalar(&bld_base->uint_bld, bld->system_values.front_facing);
+      atype = TGSI_TYPE_UNSIGNED;
       break;
 
   case TGSI_SEMANTIC_DRAWID:



More information about the mesa-commit mailing list