Mesa (master): gallium: Only define PIPE_ALIGNSTACK on x86.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Feb 19 00:13:35 UTC 2020


Module: Mesa
Branch: master
Commit: 72f7d3d5b0969aaa1c0a538dad0b3da09d9db6b6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=72f7d3d5b0969aaa1c0a538dad0b3da09d9db6b6

Author: Eric Anholt <eric at anholt.net>
Date:   Mon Dec 16 21:03:32 2019 -0800

gallium: Only define PIPE_ALIGNSTACK on x86.

At least arm and arm64 don't respect this attribute, producing compiler
warnings in lp_test_format.c.  The gcc and LLVM docs for the attribute
only talk about them being needed on x86.

Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3867>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3867>

---

 src/gallium/include/pipe/p_compiler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/include/pipe/p_compiler.h b/src/gallium/include/pipe/p_compiler.h
index 2869517389f..8c3a793e336 100644
--- a/src/gallium/include/pipe/p_compiler.h
+++ b/src/gallium/include/pipe/p_compiler.h
@@ -128,7 +128,7 @@ typedef unsigned char boolean;
 /* See http://gcc.gnu.org/onlinedocs/gcc-4.4.2/gcc/Variable-Attributes.html */
 #define PIPE_ALIGN_VAR(_alignment) __attribute__((aligned(_alignment)))
 
-#if defined(__GNUC__) && !defined(PIPE_ARCH_X86_64)
+#if defined(__GNUC__) && defined(PIPE_ARCH_X86)
 #define PIPE_ALIGN_STACK __attribute__((force_align_arg_pointer))
 #else
 #define PIPE_ALIGN_STACK



More information about the mesa-commit mailing list