Mesa (master): panfrost: Don't set shared->unk0
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Feb 27 15:48:14 UTC 2020
Module: Mesa
Branch: master
Commit: 4a10cfab7629752059cb56dc1f7e1bef87c72489
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a10cfab7629752059cb56dc1f7e1bef87c72489
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Tue Feb 25 15:32:23 2020 -0500
panfrost: Don't set shared->unk0
This field controls the size of per-thread temporaries (somehow this is
separate from the regular stack for register spilling..), though I'm not
certain on the details. Regardless this value of 0x1e despite being used
in places by the blob seems wrong and is interfering with correct sizing
of the stack.
We don't use non-spilling scratchpad yet, so this is just here to fix
some details of spilling.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3950>
---
src/gallium/drivers/panfrost/pan_mfbd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c b/src/gallium/drivers/panfrost/pan_mfbd.c
index 799fac14084..f150278bd7b 100644
--- a/src/gallium/drivers/panfrost/pan_mfbd.c
+++ b/src/gallium/drivers/panfrost/pan_mfbd.c
@@ -380,7 +380,6 @@ panfrost_emit_mfbd(struct panfrost_batch *batch, unsigned vertex_count)
.tiler = panfrost_emit_midg_tiler(batch, vertex_count),
.shared_memory = {
- .unk0 = 0x1e,
.stack_shift = shift,
.scratchpad = panfrost_batch_get_scratchpad(batch, shift, screen->thread_tls_alloc, screen->core_count)->gpu,
.shared_workgroup_count = ~0,
More information about the mesa-commit
mailing list