Mesa (master): pan/midgard: Fix load/store argument sizing
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Feb 27 21:31:27 UTC 2020
Module: Mesa
Branch: master
Commit: fd888d351f60c7dcfaff475c083c9be7bc1be626
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd888d351f60c7dcfaff475c083c9be7bc1be626
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Thu Feb 27 09:36:46 2020 -0500
pan/midgard: Fix load/store argument sizing
The swizzles are as-if they were 32-bit regardless of the bitness of the
operation, but the source sizes can and do change depending on the
flags. Account for this in the analysis.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3978>
---
src/panfrost/midgard/midgard_ra.c | 5 +++--
src/panfrost/midgard/mir.c | 11 +++++++++++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/panfrost/midgard/midgard_ra.c b/src/panfrost/midgard/midgard_ra.c
index ef3e7928044..f2fd8384cb4 100644
--- a/src/panfrost/midgard/midgard_ra.c
+++ b/src/panfrost/midgard/midgard_ra.c
@@ -682,16 +682,17 @@ install_registers_instr(
unsigned src2 = ins->src[1];
unsigned src3 = ins->src[2];
+ midgard_reg_mode m32 = midgard_reg_mode_32;
if (src2 != ~0) {
- struct phys_reg src = index_to_reg(ctx, l, src2, mir_srcsize(ins, 1));
+ struct phys_reg src = index_to_reg(ctx, l, src2, m32);
unsigned component = src.offset / src.size;
assert(component * src.size == src.offset);
ins->load_store.arg_1 |= midgard_ldst_reg(src.reg, component);
}
if (src3 != ~0) {
- struct phys_reg src = index_to_reg(ctx, l, src3, mir_srcsize(ins, 2));
+ struct phys_reg src = index_to_reg(ctx, l, src3, m32);
unsigned component = src.offset / src.size;
assert(component * src.size == src.offset);
ins->load_store.arg_2 |= midgard_ldst_reg(src.reg, component);
diff --git a/src/panfrost/midgard/mir.c b/src/panfrost/midgard/mir.c
index f07a51a6e42..2acfe445a2b 100644
--- a/src/panfrost/midgard/mir.c
+++ b/src/panfrost/midgard/mir.c
@@ -255,6 +255,17 @@ mir_typesize(midgard_instruction *ins)
midgard_reg_mode
mir_srcsize(midgard_instruction *ins, unsigned i)
{
+ if (ins->type == TAG_LOAD_STORE_4) {
+ if (OP_HAS_ADDRESS(ins->load_store.op)) {
+ if (i == 1)
+ return midgard_reg_mode_64;
+ else if (i == 2) {
+ bool zext = ins->load_store.arg_1 & 0x80;
+ return zext ? midgard_reg_mode_32 : midgard_reg_mode_64;
+ }
+ }
+ }
+
/* TODO: 16-bit textures/ldst */
if (ins->type == TAG_TEXTURE_4 || ins->type == TAG_LOAD_STORE_4)
return midgard_reg_mode_32;
More information about the mesa-commit
mailing list