Mesa (staging/19.3): 23 new commits

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jan 6 17:38:21 UTC 2020


URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eef5e0d6d5cbe9b0bb3a7c20110816fd37d85cf6
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Wed Jan 1 14:56:26 2020 +0100

    spirv: Fix glsl type assert in spir2nir.
    
    Fixes: 624789e3708 "compiler/glsl: handle case where we have multiple users for types"
    Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    (cherry picked from commit 96c9483ccf5bc9116f7b754a0ccbc09097275083)
    
    Conflicts:
    	src/compiler/spirv/spirv2nir.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae73ec44638f0281fcf6f3556973f16ca8bf6900
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Fri Jan 3 11:19:35 2020 +0100

    Revert "amd/common: Always initialize gfx9 mipmap offset/pitch."
    
    This reverts commit 973181c06cca3fe232c3a435abde31f2fc1b81ef.
    
    Requested by Marek.
    
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    (cherry picked from commit f0ed67b770619b74120444aa3788197eef28597f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=282b45e02fdc6d2f40d504bd8f64860b82d9c180
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Fri Jan 3 11:25:31 2020 +0100

    radv: Only use the gfx mipmap level offset/pitch for linear textures.
    
    The tiled-case is non-sensical for non-base mips, but Vulkan requires
    that this function handles it but at the same time does not require
    returning anything useful. So we can basically return anything.
    
    Correct tiled pitch and offset are still required for our own WSI and
    in the future getting the layouts of images with DRM format modifiers.
    Both don't have to deal with images with more than 1 level though.
    
    Fixes: 824bd0830e8 "radv: return the correct pitch for linear mipmaps on GFX10"
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2301
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2304
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    (cherry picked from commit 17741a0a05722245314e8ce9a3d5191feb63d9bd)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e15c41527d7efe160bc845ad40eb3854008f05d
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Tue Dec 31 21:28:23 2019 +0100

    amd/common: Always initialize gfx9 mipmap offset/pitch.
    
    The WSI expects pitch to be meaningful even for tiled
    textures.
    
    (It is used for the pitch in modesetting and X11)
    
    Fixes: 824bd0830e8 "radv: return the correct pitch for linear mipmaps on GFX10"
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2301
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2304
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3245>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3245>
    (cherry picked from commit 973181c06cca3fe232c3a435abde31f2fc1b81ef)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce638c9e0409615652f60da77a7bc9aa2fac39be
Author: Gert Wollny <gert.wollny at collabora.com>
Date:   Sat Dec 28 15:35:13 2019 +0100

    r600: Fix maximum line width
    
    There are only 13 bits available to store the line width, hence
    it can't be larger than 8191
    
    v2: Add Fixes tag
    
    v3: - Unify value since for all r600 archs (Konstantin Kharlamov)
        - Correct the value the line width value is emitted as a 12.4
          fixed point value of 1/2 line width on r600-r700 and as
          8 * line width on Evergreen and newer.
    
    Fixes: 06bfb2d28f7adca7edc6be9c210a7a3583023652
        r600: fork and import gallium/radeon
    
    Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
    Reviewed-by: Konstantin Kharlamov <hi-angel at yandex.ru>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
    (cherry picked from commit e8559ae4484c3240c81c0cbf49caf5be338f8395)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0878dfb9fb031b517b185d668473f4f99b2eddb5
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date:   Fri Jan 3 13:23:32 2020 -0800

    anv: Ignore some CreateInfo structs when rasterization is disabled
    
    According to the description of VkGraphicsPipelineCreateInfo(),
    pViewportState, pMultisampleState, pDepthStencilState and
    pColorBlendState must be ignored when rasterization is not enabled.
    
    This avoids potentially invalid pointers being dereferenced when
    rasterization is disabled.  Tested with `demos_x64 VK_Parameter_Zoo`
    from Renderdoc repository.
    
    v2: Don't store the `raster_enabled` as part of anv_pipeline, just
        query it from the create info.  This avoids storing a state that's
        only used during pipeline creation. (Jason)
    
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2258
    Cc: <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Eric Engestrom <eric at engestrom.ch> [v1]
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com> [v1]
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 75a19186b2aad7e588f04e1c554cdfd315dd848a)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc2ac77454ed35c782dcd9159fce3ea47421811e
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Wed Jan 1 14:42:58 2020 +0100

    nir: Add clone/hash/serialize support for non-uniform tex instructions.
    
    These were missed when the fields got added. Added it everywhere where
    texture_index got used and it made sense.
    
    Found this in "The Surge 2", where the inliner does not copy the fields,
    resulting in corruption and hangs.
    
    Fixes: 3bd54576415 "nir: Add a lowering pass for non-uniform resource access"
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1203
    Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3246>
    (cherry picked from commit 69bdc1c5fccbd9c0ef5354675b069ffb1383769e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a59f4232b6688e75d4fd99a7b61e1efc0159bc29
Author: Timur Kristóf <timur.kristof at gmail.com>
Date:   Tue Dec 31 13:39:56 2019 +0100

    aco: Fix uniform i2i64.
    
    Fixes 240 failing test cases in dEQP-VK.spirv_assembly which
    were failing due to a bad s_ashr_i32 instruction. This commit
    fixes the instruction format along with the definitions of the
    instruction.
    
    Fixes: 11f43caaeca166c96ae49dbd506b6f58dd4a13fb
    Cc: 19.3 <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
    Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
    (cherry picked from commit 11e62a9734c631fa38f1e7b415f5b98f6a28589f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9518edf0bb2d696f09533831dcbf208dfa73115
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Fri Dec 27 18:02:33 2019 -0500

    winsys/radeon: initialize pte_fragment_size
    
    Cc: 19.2 19.3 <mesa-stable at lists.freedesktop.org>
    
    Closes: #2179
    
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    (cherry picked from commit 84b82f8cd1c9d0a03e68af3a68fb0b009be70780)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=adb955dd6b0586e437689ca05a58813b407bb790
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon Dec 30 13:47:30 2019 +0100

    radv: return the correct pitch for linear mipmaps on GFX10
    
    On GFX9, the pitch of a level is always the pitch of the entire image
    but not on GFX10.
    
    This fixes graphics glithes with Halo - The Master Chief Collection.
    
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2188
    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    (cherry picked from commit 824bd0830e811a7b6347bbd5c30e0a76bc7daf60)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b02218041b15969f0e7db3b697985eea7467f225
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date:   Fri Jul 19 15:10:25 2019 +0300

    meta: Cleanup function for DrawTex
    
    Buffer object was never freed, causing memory leaks.
    
    Fixes: 76cfe2bc443 ("meta: Don't pollute the buffer object namespace in _mesa_meta_DrawTex")
    CC: Ian Romanick <ian.d.romanick at intel.com>
    
    Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1390>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1390>
    (cherry picked from commit b318bc2072d42a58b491dac3aa6118012d92e5bb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5b06ae8d707b4314dc908600e1524ea42f500f7
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Mon Dec 23 02:02:20 2019 +0100

    amd/common: Handle alignment of 96-bit formats.
    
    addrlib doesn't quite do it right, so do it ourselves.
    
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2162
    CC: <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    (cherry picked from commit 88f567b5ce3c692dbee60ba58df3af7c614e4333)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=68066d948e71c9b6204e050b7728e78cb9cc02a8
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Fri Dec 27 21:50:24 2019 +0000

    mesa: avoid returning a value in a void function
    
    Fixes: 1d1722e91070d7c37687 ("mesa: add EXT_dsa NamedProgram functions")
    Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    (cherry picked from commit a6873a8df2393777975ae3043a395d79e495b365)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dfe63a910a7576a7da653ad32d4f073444b87215
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Thu Oct 31 01:26:05 2019 +0000

    nine: fix empty-body-issues
    
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Fixes: 8d43e2b2ded0fe3c82d4 ("meson: add -Werror=empty-body to disallow `if(x);`")
    Reviewed-By: Timur Kristóf <timur.kristof at gmail.com>
    (cherry picked from commit ff3a2576a45e012b1cd8fbf73b9967083d6fce0e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e1b7ae34c05404829f07f06963243581d92727d
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Mon Oct 28 23:47:48 2019 +0000

    amd: fix empty-body issues
    
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Fixes: 8d43e2b2ded0fe3c82d4 ("meson: add -Werror=empty-body to disallow `if(x);`")
    Reviewed-By: Timur Kristóf <timur.kristof at gmail.com>
    (cherry picked from commit 51569e525afc5e7173f12b0a3f1ba0e92425407f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b9b7fb0e86a2d1648a20828c8b6509cd84344701
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Thu Nov 7 17:29:00 2019 +0000

    util/format: remove left-over util_format_description_table declaration
    
    Fixes: 3c45c4bc44310c1af4f0 ("util: Cope with the fact that formats in u_format.csv are not ordered.")
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Eric Anholt <eric at anholt.net>
    (cherry picked from commit cc7a64f101be0939c17231257701230859dee90d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=425da3ba48f89ca4daec3858038a342656e158a7
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Tue Dec 24 14:44:03 2019 +0100

    radv: Expose all sample counts for integer formats as well.
    
    Things work the same between float and integer.
    
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2261
    CC: <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit a435f002c40f5adc99d37e65cf6b8bd478dc8e71)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a1a07e900a4debcbcb3fc206a8ad22e62034520
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Mon Dec 23 22:19:29 2019 -0600

    anv: Properly advertise sampledImageIntegerSampleCounts
    
    We support the same set of samples for integer color formats as for
    non-integer.  We've been advertising it wrong since before the initial
    Vulkan 1.0 release. :-(
    
    Fixes: d68974530371 "vk/0.210.0: Rework device features and limits"
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    (cherry picked from commit ac70442ce1f061a42649f7c88c6a8d278fb73fb5)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a0c58ff355eefb565a40306d79aecdeba403dc3
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Tue Dec 17 10:41:39 2019 +0100

    radeon/vcn2: enable rate control for hevc encoding
    
    Based on b0626c1f306 ("radeon/vcn: enable rate control for hevc encoding").
    
    Reviewed-by: Boyuan Zhang <boyuan.zhang at amd.com>
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2225
    Fixes: 587b9c5dae6 ("radeon/vcn: implement vcn 2.0 encode")
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3134>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3134>
    (cherry picked from commit 9c2a3b4e7566108ad336c253e3cd0fcb2629ae6d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7aa665d520aff043b5a8c9b4be7b43df7e31cd9
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date:   Fri Nov 29 09:44:43 2019 +0100

    etnaviv: update resource status after flushing
    
    Currently piglit spec at arb_occlusion_query@occlusion_query_conform
    spins for ever as the resource status is never reset. See
    etna_hw_get_query_result(..) for more details.
    
    Fixes: 1456aa61cc5 ("etnaviv: Rework resource status tracking")
    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
    Tested-by: Marek Vasut <marex at denx.de>
    (cherry picked from commit 6e75f2172b5cc9298dee6f17e55bed60ce0c15fb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1ea3746cf0bd20bf115484a4a00dc4afd777cc3
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Dec 18 13:29:39 2019 +0100

    radv/gfx10: fix the out-of-bounds check for vertex descriptors
    
    When stride is 0, it should check against the offset not the index.
    
    This fixes black character models with Beat Saber and missing snow
    with Dragon Quest.
    
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2233
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1975
    Cc: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3147>
    (cherry picked from commit f3cccd05d9f6e9d05c18d1a3a5f9eb863e4f264b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=25e99501b461f32a8273a2e6906c0ee55799933b
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date:   Wed Dec 18 17:48:26 2019 +0200

    loader: fix close on uninitialized file descriptor value
    
    Using a drm syscall layer faking a kernel driver :
    
      ==581460== Conditional jump or move depends on uninitialised value(s)
      ==581460==    by 0x48A4C2B: close (drm-hooks.cpp:185)
      ==581460==    by 0x5A815F1: dri3_alloc_render_buffer (loader_dri3_helper.c:1469)
      ==581460==    by 0x5A82050: dri3_get_buffer (loader_dri3_helper.c:1827)
      ==581460==    by 0x5A82662: loader_dri3_get_buffers (loader_dri3_helper.c:2028)
      ==581460==    by 0x6C78109: intel_update_image_buffers (brw_context.c:1870)
      ==581460==    by 0x6C77805: intel_update_renderbuffers (brw_context.c:1499)
      ==581460==    by 0x6C7789D: intel_prepare_render (brw_context.c:1520)
      ==581460==    by 0x6C773D4: intelMakeCurrent (brw_context.c:1341)
    
    Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Fixes: 069fdd5f9fac ("egl/x11: Support DRI3 v1.1")
    Reviewed-by: Eric Anholt <eric at anholt.net>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3152>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3152>
    (cherry picked from commit fc2552b6445a1295c18acf8798411da85bbc5387)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=90b3a254fa0fcbaf51bf65aef451b44e8423e5eb
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Wed Dec 18 10:21:40 2019 +0100

    radv: Limit workgroup size to 1024.
    
    Fixes a hang with geekbench.
    
    The existence of RX 580 and NAVI10 results shows that the generations
    before and after this do not have the issue. (They show up on the
    website). So this is likely a GFX9 only issue.
    
    This is not something weird like LDS size since none of the shaders
    seem to use LDS.
    
    CC: <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3145>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3145>
    (cherry picked from commit a9a3108be774aea620fa4fc726c33100d9a49add)




More information about the mesa-commit mailing list