Mesa (master): aco: better handle neg/abs of sgprs
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jan 13 14:07:17 UTC 2020
Module: Mesa
Branch: master
Commit: 21eafe30df5d5fa02a908e277add7adb7816ec4c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=21eafe30df5d5fa02a908e277add7adb7816ec4c
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Dec 13 16:59:54 2019 +0000
aco: better handle neg/abs of sgprs
isel/label_instruction currently doesn't create these but we should
probably check anyway.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
---
src/amd/compiler/aco_optimizer.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index eef2532e3cd..68831a653a3 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -924,7 +924,8 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
break;
}
case aco_opcode::v_and_b32: /* abs */
- if (!instr->usesModifiers() && instr->operands[0].constantEquals(0x7FFFFFFF) && instr->operands[1].isTemp())
+ if (!instr->usesModifiers() && instr->operands[0].constantEquals(0x7FFFFFFF) &&
+ instr->operands[1].isTemp() && instr->operands[1].getTemp().type() == RegType::vgpr)
ctx.info[instr->definitions[0].tempId()].set_abs(instr->operands[1].getTemp());
else
ctx.info[instr->definitions[0].tempId()].set_bitwise(instr.get());
@@ -933,7 +934,7 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
if (!instr->usesModifiers() && instr->operands[0].constantEquals(0x80000000u) && instr->operands[1].isTemp()) {
if (ctx.info[instr->operands[1].tempId()].is_neg()) {
ctx.info[instr->definitions[0].tempId()].set_temp(ctx.info[instr->operands[1].tempId()].temp);
- } else {
+ } else if (instr->operands[1].getTemp().type() == RegType::vgpr) {
if (ctx.info[instr->operands[1].tempId()].is_abs()) { /* neg(abs(x)) */
instr->operands[1].setTemp(ctx.info[instr->operands[1].tempId()].temp);
instr->opcode = aco_opcode::v_or_b32;
More information about the mesa-commit
mailing list