Mesa (master): etnaviv: Fix assert when try to accumulate an invalid fd

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 14 17:52:27 UTC 2020


Module: Mesa
Branch: master
Commit: 1607123ae7504ead15129b2a90506811d9e26b6d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1607123ae7504ead15129b2a90506811d9e26b6d

Author: Marco Felsch <m.felsch at pengutronix.de>
Date:   Thu Dec  5 17:04:11 2019 +0100

etnaviv: Fix assert when try to accumulate an invalid fd

Check if it is a valid fd before merging it to the context's fd.

Signed-off-by: Marco Felsch <m.felsch at pengutronix.de>
Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
Reviewed-by: Jonathan Marek <jonathan at marek.ca>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3381>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3381>

---

 src/gallium/drivers/etnaviv/etnaviv_fence.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_fence.c b/src/gallium/drivers/etnaviv/etnaviv_fence.c
index c0684bccf29..b2400b6aca3 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_fence.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_fence.c
@@ -88,7 +88,8 @@ etna_fence_server_sync(struct pipe_context *pctx,
 {
    struct etna_context *ctx = etna_context(pctx);
 
-   sync_accumulate("etnaviv", &ctx->in_fence_fd, pfence->fence_fd);
+   if (pfence->fence_fd != -1)
+      sync_accumulate("etnaviv", &ctx->in_fence_fd, pfence->fence_fd);
 }
 
 static int



More information about the mesa-commit mailing list