Mesa (master): aco: Don't skip combine_instruction when definitions[1] is used.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 14 20:42:33 UTC 2020


Module: Mesa
Branch: master
Commit: 1c44129db30db70dc6a0e1906b5a8efa7f8d00cf
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c44129db30db70dc6a0e1906b5a8efa7f8d00cf

Author: Timur Kristóf <timur.kristof at gmail.com>
Date:   Tue Nov 19 13:38:34 2019 +0100

aco: Don't skip combine_instruction when definitions[1] is used.

Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>

---

 src/amd/compiler/aco_optimizer.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index bf075b6ffab..84c5e4b78ab 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -2150,7 +2150,7 @@ bool apply_omod_clamp(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
 
 void combine_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
 {
-   if (instr->definitions.empty() || !ctx.uses[instr->definitions[0].tempId()])
+   if (instr->definitions.empty() || is_dead(ctx.uses, instr.get()))
       return;
 
    if (instr->isVALU()) {



More information about the mesa-commit mailing list