Mesa (staging/19.3): 25 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Jan 14 22:04:40 UTC 2020
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a7e014b4dd601e4c3445c026133373aec123986
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Dec 16 13:30:10 2019 +0000
aco: don't DCE atomics with return values
We don't create atomics with definitions if they are not used in NIR, but
our own DCE can remove the uses if an export turns out to be null.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit 69bed1c9186c3e24ad54089218d58c5f7b83befe)
Conflicts resolved by Dylan Baker
Conflicts:
src/amd/compiler/aco_opcodes.py
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=83821ebb25bb9ed844ff8e5e21cb214b1f96e90f
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Mon Jan 13 15:48:12 2020 -0800
intel/fs: Only use SLM fence in compute shaders
Fixes: b390ff35170 ("intel/fs: Add support for SLM fence in Gen11")
Fixes: e142061399c ("intel/fs: Implement scoped_memory_barrier")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit edf6a40cb2a09d58f9244abf0a1432a836a350ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b55c8ec5200f74ae64b8dd2fc3e2a8b8bbb20315
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Jan 14 16:10:21 2020 +0200
anv: only use VkSamplerCreateInfo::compareOp if enabled
The spec says nothing about the validity of the compareOp field when
compareEnable is false.
v2: use vulkan enum to pick default value (Caio)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2350
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3387>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3387>
(cherry picked from commit a19cdf989b1cca7126a29a42e5f28e8c7823e937)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c8f3ca4a1392d947dac3d52b4fefda18ad44c9a
Author: Eric Anholt <eric at anholt.net>
Date: Mon Jan 13 13:06:01 2020 -0800
mesa: Fix detection of invalidating both depth and stencil.
Fixes an extra 1024x1024x4 MSAA Z/S store on WebGL fishtank on cheza.
Reported-by: Dave Airlie <airlied at redhat.com>
Fixes: db2ae5112106 ("mesa: Skip partial InvalidateFramebuffer of packed depth/stencil.")
Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
Reviewed-by: Rob Clark <robdclark at chromium.org>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3370>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3370>
(cherry picked from commit 3be4b89c038554ceb95ba24c00f50c0f2db3a646)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ca67b73b2dd112833dbe0670e0a971b2bc1e78d
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Jan 13 13:49:57 2020 -0600
anv: Memset array properties
This is probably better than possibly leaving those bytes uninitialized
even if the app will theoretically not use them.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Reviewed-by: Ivan Briano <ivan.briano at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3369>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3369>
(cherry picked from commit 7978f2401bba7e60f255337a394fd132082be9aa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1ebe018e4415c6a7c74ec0839a906abaf7d4bf93
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Jan 13 12:55:41 2020 -0600
anv: Don't over-advertise descriptor indexing features
We should only advertise sub-features if we advertise the extension.
Fixes: 6e230d7607f "anv: Implement VK_EXT_descriptor_indexing"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Reviewed-by: Ivan Briano <ivan.briano at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3369>
(cherry picked from commit d36eed3e695d8f39495a3d81373a8c47853bae7e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c4cd47bad943bfdd36f3de68ee5a4da7f1247b74
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 10 15:30:02 2020 -0600
intel/blorp: Fill out all the dwords of MI_ATOMIC
This makes us valgrind clean again.
Fixes: 9175c7058efb "intel/blorp: Make blorp update the clear color..."
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3366>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3366>
(cherry picked from commit d7ff137445b9bfd0cf15d176d0d152d16634559f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=77b8fc9dae14a4e92df170351e34c0772b3cb0da
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Jan 7 16:14:56 2020 -0600
intel/vec4: Support scoped_memory_barrier
Fixes: 06aecb14c0476 "anv: Implement VK_KHR_vulkan_memory_model"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3307>
(cherry picked from commit ada49bae5e039b10913bc61ba7b037227e7e49aa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=46b4ffb44d8adf456bcbade0bae5ef3068f00655
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Dec 16 13:58:16 2019 +0000
aco: disable add combining for ds_swizzle_b32
ds_bpermute_b32/ds_permute_b32 are fine, I think
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit ef8abfa7908974f571786e83b047b187af0e48c7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=288203f47b97727f8ceed5076b28fbaa99a0b32a
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Dec 16 11:29:08 2019 +0000
aco: set exec_potentially_empty for demotes
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit 8f291dc14600c614788301e3265ff7f0f48b8b0d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b12fba88bfc3171ba1cc6a4370e5c82d64b533bf
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Sep 24 17:21:51 2019 +0100
aco: fix uninitialized data in the binary
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof at gmail.com>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit bbac52873f4248c2f545f12137bd24071a8043cc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fb11c4b9e2b8c896d189a1bd02bb08b12fc415e
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Dec 9 18:00:55 2019 +0000
aco: fix imageSize()/textureSize() with large buffers on GFX8
Tested on Navi by using dEQP-VK.image.image_size.buffer.* and the GFX8
path with the size multipled by the stride.
dEQP-VK.image.image_size.buffer.* was also run with the tests modified to
use a 96bit format.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 93c8ebfa780 ('aco: Initial commit of independent AMD compiler')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit fcd6d8324560b5897586cbf8161f9b46bff5d11f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=729d6326860a16bdb5fa93dd4c6ab50f1a94999c
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Dec 9 13:38:47 2019 +0000
aco: set vm for pos0 exports on GFX10
RADV's LLVM backend and radeonsi does the same thing.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: 19.3 <mesa-stable at lists.freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
(cherry picked from commit 49bcd06f974dcd8f60b4aa7d93bf1843439126a2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8df6be9b918bbd75584a594e9f0ac3a9db799480
Author: Francisco Jerez <currojerez at riseup.net>
Date: Fri Dec 27 16:08:04 2019 -0800
intel/fs/gen8+: Fix r127 dst/src overlap RA workaround for EOT message payload.
The problem occured when the return payload of a SIMD8 SEND
instruction was re-used as source payload of an EOT SEND message. In
such cases the interference edge added by that workaround between the
payload and grf127_send_hack_node would have no effect, because the
payload would be allocated to a fixed range of registers containing
r127 by the special handling of EOT message payloads in the same
function. This would cause things to blow up if the source payload of
the first SIMD8 message ended up being allocated to a range which
happened to overlap the destination.
Fix it by avoiding r127 altogether in the allocation of EOT message
payloads.
The problem can be reproduced on ICL with the fp-indirections2 Piglit
test-case in combination with the other optimizer changes of this
series.
Fixes: 232ed8980217 "i965/fs: Register allocator shoudn't use grf127 for sends dest"
Cc: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 0703eab0120f20451e75ba8d4ce065350ad36fef)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=aa3ab59a721003b93fda8b415160473d2aac265e
Author: Francisco Jerez <currojerez at riseup.net>
Date: Sun Nov 24 16:12:12 2019 -0800
intel/fs/gen11+: Handle ROR/ROL in lower_simd_width().
Prevents invalid code from being emitted for ROR/ROL instructions in
SIMD32 shaders.
The problem can be reproduced with the following tests while forcing
SIMD32 to be used for fragment shaders:
piglit.shaders.glsl-rotate-left
piglit.shaders.glsl-rotate-right
However the issue could occur in production already with compute
shaders and a workgroup size large enough to trigger SIMD32 dispatch.
Fixes: 83fdec0f0de "intel/compiler: Enable the emission of ROR/ROL instructions"
Cc: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 0a6e46d44d30fd10ee6784c9a6920b4d127e9810)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ea84c5bee1ba26b668f6358946a992c36899f001
Author: Francisco Jerez <currojerez at riseup.net>
Date: Fri Dec 27 14:10:31 2019 -0800
glsl: Fix software 64-bit integer to 32-bit float conversions.
The current implementation was broken for any integers between 2^24
and 2^30 (it would return zero for me on ICL). The reason is that for
such integers we wouldn't take the 'if (0 <= shiftCount)' early return
path, however 'shiftCount + 7' would be positive, leading to a
negative 'count' argument passed to __shift64RightJamming(), which
would give undefined results.
This reworks the affected conversion functions to use either
__shortShift64Left() or __shift64RightJamming() based on the sign of
the final shift count, which should avoid the problem. In addition
this should qualify as a clean-up/optimization -- This implementation
of the conversion functions translates to 7 instructions less than the
original on Intel hardware.
This fixes the 'KHR-GL46.shader_ballot_tests.ShaderBallotFunctionBallot'
conformance tests on soft fp64 hardware with large enough subgroup
size (>16).
Fixes: d5cf6e92b4f7 "glsl: Add built-in functions to do uint64_to_fp32(uint64_t)"
Fixes: c9d333a6b76e "glsl: Add built-in functions to do int64_to_fp32(int64_t)"
Cc: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
(cherry picked from commit a30bb25a7a495db7b7cb3be50431029f48019fc3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db1b7341f17408d608ced5cb39f2d15b00346657
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Fri Jan 10 17:37:13 2020 +0200
mesa/st: fix a memory leak in get_version
This patch prevents memory leak in get_version function in st_manager.c
This issue was found by valgrind:
16 bytes in 1 blocks are definitely lost in loss record 6 of 1,418
at 0x483CD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x63D9476: st_init_extensions (st_extensions.c:1679)
by 0x63B803B: get_version (st_manager.c:1271)
by 0x63B8124: st_api_query_versions (st_manager.c:1289)
by 0x63266EF: dri_init_screen_helper (dri_screen.c:583)
by 0x6321B12: dri2_init_screen (dri2.c:2110)
by 0x631AACC: driCreateNewScreen2 (dri_util.c:155)
by 0x5D58192: dri3_create_screen (dri3_glx.c:897)
by 0x5D39829: AllocAndFetchScreenConfigs (glxext.c:815)
by 0x5D39C57: __glXInitialize (glxext.c:941)
by 0x5D3290A: GetGLXPrivScreenConfig (glxcmds.c:174)
by 0x5D34F38: glXQueryExtensionsString (glxcmds.c:1307)
Fixes: eca8032f20d0970184843d98e2bddb688e94a3a9 ("gallium: Add ARB_gl_spirv support")
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3345>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3345>
(cherry picked from commit ebaab89761aad59c4debec67c3ec24a96cb82dd1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=31fa1c79371b71b07a6ef357fa2586ca3409f773
Author: Lasse Lopperi <lasse.lopperi at ge.com>
Date: Fri Jan 10 10:47:55 2020 +0200
freedreno/drm: Fix memory leak in softpin implementation
Free the memory allocated for cmds/reloc_bos array when destoying the
associated ringbuffer.
For similar fix for the non-softpin implementation see:
https://gitlab.freedesktop.org/mesa/mesa/commit/d014af98b7afc69f4f733c8b8b6f2e3438e68407
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2324
Fixes: f3cc0d2 ("freedreno: import libdrm_freedreno + redesign submit")
Signed-off-by: Lasse Lopperi <lasse.lopperi at ge.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3342>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3342>
(cherry picked from commit 3de2774dcb85fb2f87ae65a854fc5f25f0f34a91)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6cab261441e54a0ed099dfa1da9ffe93162c5d6b
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Jan 9 14:59:49 2020 +0100
radeonsi: release saved resources in si_compute_do_clear_or_copy
Fixes: 9b331e462e5 ("radeonsi: use compute shaders for clear_buffer & copy_buffer")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit a5fe84aefb6858bee123f60b330db1e0287f9cc0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=964883551dcce75f71ba330991c463ae16de7420
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Jan 9 14:41:48 2020 +0100
radeonsi: release saved resources in si_compute_copy_image
Fixes: 1b25d340b79 ("radeonsi: use compute for resource_copy_region when possible")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 1acf714d579114ff591c00989b2e6a97de8830b8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4dfdceeedcf0bd09386871bdb7682f177ebd91ac
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Jan 9 14:40:44 2020 +0100
radeonsi: release saved resources in si_compute_clear_render_target
Fixes: 984fd735152 ("radeonsi: use compute for clear_render_target when possible")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit e1e87466ae7d46c564fdd3154003ae3cddf3147b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=583d870f5649f3636f86dc0b57f747570312da88
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Jan 9 14:39:24 2020 +0100
radeonsi: release saved resources in si_compute_expand_fmask
Fixes: 095a58204d9 ("radeonsi: expand FMASK before MSAA image stores are used")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 6c019e28caf2124b13d2ea5d87e936bf43d8b4fd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e8b9584f3b260eb595d27dc2d71ef4c96c3e1c5
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Jan 9 14:32:11 2020 +0100
radeonsi: release saved resources in si_retile_dcc
Fixes: 1f21396431a ("radeonsi: add support for displayable DCC for multi-RB chips")
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2330
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 9211cbe07a0ffb0abdaf3da68f7aa3ee00a430d7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=852c88ed9441cba7a6ff5b5d00aacbe92a12fd0e
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Jan 8 14:47:11 2020 -0600
anv: Flag descriptors dirty when gl_NumWorkgroups is used
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
(cherry picked from commit ae72d1238c758404df045a82c36803dbccd93b31)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c6a861a2b0aa19201bb08b4c7c133c1dd985285c
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Dec 18 09:16:44 2019 +0200
anv: fix intel perf queries availability writes
The availability is not written at the location changed in
ee6fbb95a74d...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: ee6fbb95a74d ("anv: Properly handle host query reset of performance queries")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 60e0db3bfb05660fb3d2c868838635d667f8966a)
More information about the mesa-commit
mailing list