Mesa (master): anv: initialize clear_color_is_zero_one

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 21 16:12:20 UTC 2020


Module: Mesa
Branch: master
Commit: 5fede43fe0c7b9c5f8f79cba81637a2a7473abb4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fede43fe0c7b9c5f8f79cba81637a2a7473abb4

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Tue Jan 21 16:48:11 2020 +0200

anv: initialize clear_color_is_zero_one

Fixes following valgrind warning:

   ==12508== Conditional jump or move depends on uninitialised value(s)
   ==12508==    at 0x2CCD8B79: cmd_buffer_begin_subpass (genX_cmd_buffer.c:4599)
   ==12508==    by 0x2CCDA72B: gen9_CmdBeginRenderPass (genX_cmd_buffer.c:5275)

Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3487>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3487>

---

 src/intel/vulkan/genX_cmd_buffer.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index 0e9f7ce2e23..edde918dc6b 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -438,6 +438,11 @@ depth_stencil_attachment_compute_aux_usage(struct anv_device *device,
    att_state->aux_usage = ISL_AUX_USAGE_NONE;
    att_state->input_aux_usage = ISL_AUX_USAGE_NONE;
 
+   /* This is unused for depth/stencil but valgrind complains if it
+    * isn't initialized
+    */
+   att_state->clear_color_is_zero_one = false;
+
    if (GEN_GEN == 7) {
       /* We don't do any HiZ or depth fast-clears on gen7 yet */
       att_state->fast_clear = false;



More information about the mesa-commit mailing list