Mesa (master): aco: Fix maybe-uninitialized warnings.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 22 10:28:39 UTC 2020


Module: Mesa
Branch: master
Commit: 533a20dbd56b8af24ba2df4d2a973d46f8efabbd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=533a20dbd56b8af24ba2df4d2a973d46f8efabbd

Author: Timur Kristóf <timur.kristof at gmail.com>
Date:   Tue Jan 21 13:49:00 2020 +0100

aco: Fix maybe-uninitialized warnings.

Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3483>

---

 src/amd/compiler/aco_assembler.cpp             | 2 ++
 src/amd/compiler/aco_instruction_selection.cpp | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/amd/compiler/aco_assembler.cpp b/src/amd/compiler/aco_assembler.cpp
index 241e3d44309..c7088a498b5 100644
--- a/src/amd/compiler/aco_assembler.cpp
+++ b/src/amd/compiler/aco_assembler.cpp
@@ -512,6 +512,8 @@ void emit_instruction(asm_context& ctx, std::vector<uint32_t>& out, Instruction*
             encoding = (0b110100 << 26);
          } else if (ctx.chip_class == GFX10) {
             encoding = (0b110101 << 26);
+         } else {
+            unreachable("Unknown chip_class.");
          }
 
          if (ctx.chip_class <= GFX7) {
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index ee6f02f4bec..873f9b01380 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -7937,6 +7937,8 @@ static void emit_stream_output(isel_context *ctx,
       case 4:
          opcode = aco_opcode::buffer_store_dwordx4;
          break;
+      default:
+         unreachable("Unsupported dword count.");
       }
 
       aco_ptr<MUBUF_instruction> store{create_instruction<MUBUF_instruction>(opcode, Format::MUBUF, 4, 0)};



More information about the mesa-commit mailing list