Mesa (master): panfrost: Fix crash in compute variant allocation

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 22 14:09:20 UTC 2020


Module: Mesa
Branch: master
Commit: 4936120230f07b959ec902aca989fdeae4e80d55
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4936120230f07b959ec902aca989fdeae4e80d55

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jan 20 16:01:53 2020 -0500

panfrost: Fix crash in compute variant allocation

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Fixes: d8a3501f1b2 ("panfrost: Dynamically allocate shader variants")
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3515>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3515>

---

 src/gallium/drivers/panfrost/pan_compute.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/panfrost/pan_compute.c b/src/gallium/drivers/panfrost/pan_compute.c
index 905e6e234e0..9e3306b673f 100644
--- a/src/gallium/drivers/panfrost/pan_compute.c
+++ b/src/gallium/drivers/panfrost/pan_compute.c
@@ -46,7 +46,8 @@ panfrost_create_compute_state(
         so->cbase = *cso;
         so->is_compute = true;
 
-        struct panfrost_shader_state *v = &so->variants[0];
+        struct panfrost_shader_state *v = calloc(1, sizeof(*v));
+        so->variants = v;
 
         so->variant_count = 1;
         so->active_variant = 0;



More information about the mesa-commit mailing list