Mesa (master): egl: drop confusing mincore() error message

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 22 18:41:07 UTC 2020


Module: Mesa
Branch: master
Commit: 7d7d1da1ac4b02c92da1624d3eb16004268dabac
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d7d1da1ac4b02c92da1624d3eb16004268dabac

Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Fri Dec 27 20:59:26 2019 +0000

egl: drop confusing mincore() error message

A user came to me asking how to fix this error, but it's entirely
expected that `get_wl_surface_proxy()` on recent enough wayland
compositors will always print it.
Let's just remove the message altogether, it is basically never useful.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3219>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3219>

---

 src/egl/main/eglglobals.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/egl/main/eglglobals.c b/src/egl/main/eglglobals.c
index 5760edc3d3c..8a8c03c924f 100644
--- a/src/egl/main/eglglobals.c
+++ b/src/egl/main/eglglobals.c
@@ -38,7 +38,6 @@
 #include "egldevice.h"
 #include "egldisplay.h"
 #include "egldriver.h"
-#include "egllog.h"
 
 #include "util/macros.h"
 
@@ -173,7 +172,6 @@ _eglPointerIsDereferencable(void *p)
    addr &= ~(page_size - 1);
 
    if (mincore((void *) addr, page_size, &valid) < 0) {
-      _eglLog(_EGL_DEBUG, "mincore failed: %m");
       return EGL_FALSE;
    }
 



More information about the mesa-commit mailing list