Mesa (master): anv/apply_pipeline_layout: Initialize the nir_builder before use

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 24 05:48:22 UTC 2020


Module: Mesa
Branch: master
Commit: 8a135ff6e5f5813c110ea0a4ae7d1f3c0cb37115
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a135ff6e5f5813c110ea0a4ae7d1f3c0cb37115

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Thu Jan 23 21:24:15 2020 -0600

anv/apply_pipeline_layout: Initialize the nir_builder before use

Fixes: #2410
Fixes: 3c754900b5f "nir: don't emit ishl in _nir_mul_imm() if backend doesn't support bitops"
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3548>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3548>

---

 src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
index 0c0e44f657b..5be8cc22f99 100644
--- a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
+++ b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
@@ -1328,6 +1328,8 @@ anv_nir_apply_pipeline_layout(const struct anv_physical_device *pdevice,
       if (!function->impl)
          continue;
 
+      nir_builder_init(&state.builder, function->impl);
+
       /* Before we do the normal lowering, we look for any SSBO operations
        * that we can lower to the BTI model and lower them up-front.  The BTI
        * model can perform better than the A64 model for a couple reasons:
@@ -1360,7 +1362,6 @@ anv_nir_apply_pipeline_layout(const struct anv_physical_device *pdevice,
        */
       lower_direct_buffer_access(function->impl, &state);
 
-      nir_builder_init(&state.builder, function->impl);
       nir_foreach_block(block, function->impl)
          apply_pipeline_layout_block(block, &state);
       nir_metadata_preserve(function->impl, nir_metadata_block_index |



More information about the mesa-commit mailing list