Mesa (master): radv: enable ACO support for GFX6

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 24 18:51:18 UTC 2020


Module: Mesa
Branch: master
Commit: 4a553212fa171ddaf849d4abb2d67208390cd769
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a553212fa171ddaf849d4abb2d67208390cd769

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri Jan 10 14:53:51 2020 +0100

radv: enable ACO support for GFX6

CTS should pass, as well as Crucible and the few number of Piglit tests.

List of game benchmarks tested:
- Dawn of War 3
- Serious Sam 2017
- Shadow of The Tomb Raider
- The Talos Principle
- Thrones of Britannia
- Total Warhammer 2
- Total War: Three Kingdoms

Note that F12017 hangs with or without ACO on GFX6 at the moment.

My whole pipelinedb (~30 games) doesn't trigger any compiler crashes.

Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2401
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3533>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3533>

---

 src/amd/vulkan/radv_device.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 2b222d331a3..52451575e98 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -398,10 +398,6 @@ radv_physical_device_init(struct radv_physical_device *device,
 	radv_handle_env_var_force_family(device);
 
 	device->use_aco = instance->perftest_flags & RADV_PERFTEST_ACO;
-	if (device->rad_info.chip_class < GFX7 && device->use_aco) {
-		fprintf(stderr, "WARNING: disabling ACO on unsupported GPUs.\n");
-		device->use_aco = false;
-	}
 
 	snprintf(device->name, sizeof(device->name),
 		 "AMD RADV%s %s (LLVM " MESA_LLVM_VERSION_STRING ")", device->use_aco ? "/ACO" : "",



More information about the mesa-commit mailing list