Mesa (master): isl: add gen12 comment about CCS for linear tiling
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Sun Jan 26 21:02:37 UTC 2020
Module: Mesa
Branch: master
Commit: 8bd92a15cf28714f1752fbdbafcf78f575e16f13
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8bd92a15cf28714f1752fbdbafcf78f575e16f13
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Jan 24 23:45:41 2020 +0200
isl: add gen12 comment about CCS for linear tiling
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3551>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3551>
---
src/intel/isl/isl.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index d68ac324d07..f737f8b3b53 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -2020,6 +2020,16 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
if (surf->tiling != ISL_TILING_Y0)
return false;
+ /* BSpec 44930:
+ *
+ * Linear CCS is only allowed for Untyped Buffers but only via HDC
+ * Data-Port messages.
+ *
+ * We probably want to limit linear CCS to storage usage and check that
+ * the shaders actually use only untyped messages.
+ */
+ assert(surf->tiling != ISL_TILING_LINEAR);
+
switch (isl_format_get_layout(surf->format)->bpb) {
case 8: ccs_format = ISL_FORMAT_GEN12_CCS_8BPP_Y0; break;
case 16: ccs_format = ISL_FORMAT_GEN12_CCS_16BPP_Y0; break;
More information about the mesa-commit
mailing list