Mesa (master): radeonsi: Clear uninitialized variable

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 28 16:47:33 UTC 2020


Module: Mesa
Branch: master
Commit: 0d99ff54cc3fb1dd85044f8971f6686138a5f149
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d99ff54cc3fb1dd85044f8971f6686138a5f149

Author: Drew Davenport <ddavenport at chromium.org>
Date:   Mon Jan 27 11:13:19 2020 -0700

radeonsi: Clear uninitialized variable

|view| was not initialized leading to flaky test failures in SkQP
test unitTest_ES2BlendWithNoTexture.

Fixes: 029bfa3d253 "radeonsi: add ability to bind images as image buffers"

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3592>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3592>

---

 src/gallium/drivers/radeonsi/si_descriptors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c
index 193029820e5..fa2174bac5d 100644
--- a/src/gallium/drivers/radeonsi/si_descriptors.c
+++ b/src/gallium/drivers/radeonsi/si_descriptors.c
@@ -903,7 +903,7 @@ void si_update_ps_colorbuf0_slot(struct si_context *sctx)
 
 	if (surf) {
 		struct si_texture *tex = (struct si_texture*)surf->texture;
-		struct pipe_image_view view;
+		struct pipe_image_view view = {0};
 
 		assert(tex);
 		assert(!tex->is_depth);



More information about the mesa-commit mailing list