Mesa (master): turnip: remove unused descriptor state dirty

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 29 21:17:30 UTC 2020


Module: Mesa
Branch: master
Commit: d5c32db076014be206972858da93ff87419863c1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d5c32db076014be206972858da93ff87419863c1

Author: Alejandro Piñeiro <apinheiro at igalia.com>
Date:   Wed Jan 29 14:20:19 2020 +0100

turnip: remove unused descriptor state dirty

It was only used to be initialized to zero. Not even updated as
descriptor sets are bind.

As far as I understand, setting the bit TU_CMD_DIRTY_DESCRIPTOR_SET on
tu_cmd_state.dirty is used instead.

Reviewed-by: Jonathan Marek <jonathan at marek.ca>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3624>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3624>

---

 src/freedreno/vulkan/tu_cmd_buffer.c | 1 -
 src/freedreno/vulkan/tu_private.h    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/freedreno/vulkan/tu_cmd_buffer.c b/src/freedreno/vulkan/tu_cmd_buffer.c
index a11cab52945..b9b9e2e0193 100644
--- a/src/freedreno/vulkan/tu_cmd_buffer.c
+++ b/src/freedreno/vulkan/tu_cmd_buffer.c
@@ -1731,7 +1731,6 @@ tu_reset_cmd_buffer(struct tu_cmd_buffer *cmd_buffer)
    tu_cs_reset(cmd_buffer->device, &cmd_buffer->sub_cs);
 
    for (unsigned i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; i++) {
-      cmd_buffer->descriptors[i].dirty = 0;
       cmd_buffer->descriptors[i].valid = 0;
       cmd_buffer->descriptors[i].push_dirty = false;
    }
diff --git a/src/freedreno/vulkan/tu_private.h b/src/freedreno/vulkan/tu_private.h
index 81f71ad4487..a71e0fd138c 100644
--- a/src/freedreno/vulkan/tu_private.h
+++ b/src/freedreno/vulkan/tu_private.h
@@ -778,7 +778,6 @@ tu_get_perftest_option_name(int id);
 struct tu_descriptor_state
 {
    struct tu_descriptor_set *sets[MAX_SETS];
-   uint32_t dirty;
    uint32_t valid;
    struct tu_push_descriptor_set push_set;
    bool push_dirty;



More information about the mesa-commit mailing list