Mesa (master): intel/compiler: add and fix up fallthrough comments for gcc warnings

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jul 2 04:11:19 UTC 2020


Module: Mesa
Branch: master
Commit: 1a8f91805031f408c9e1481a01345303405c9d4b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a8f91805031f408c9e1481a01345303405c9d4b

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Wed Jul  1 16:30:01 2020 +1000

intel/compiler: add and fix up fallthrough comments for gcc warnings

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5714>

---

 src/intel/compiler/brw_compile_sf.c | 6 +++---
 src/intel/compiler/brw_disasm.c     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/intel/compiler/brw_compile_sf.c b/src/intel/compiler/brw_compile_sf.c
index 51eb9b0dbf9..b750d27f949 100644
--- a/src/intel/compiler/brw_compile_sf.c
+++ b/src/intel/compiler/brw_compile_sf.c
@@ -167,9 +167,9 @@ static void do_twoside_color( struct brw_sf_compile *c )
    brw_IF(p, BRW_EXECUTE_4);
    {
       switch (c->nr_verts) {
-      case 3: copy_bfc(c, c->vert[2]);
-      case 2: copy_bfc(c, c->vert[1]);
-      case 1: copy_bfc(c, c->vert[0]);
+      case 3: copy_bfc(c, c->vert[2]); /* fallthrough */
+      case 2: copy_bfc(c, c->vert[1]); /* fallthrough */
+      case 1: copy_bfc(c, c->vert[0]); /* fallthrough */
       }
    }
    brw_ENDIF(p);
diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c
index 486f55d7bec..23c55fb65ea 100644
--- a/src/intel/compiler/brw_disasm.c
+++ b/src/intel/compiler/brw_disasm.c
@@ -2064,8 +2064,8 @@ brw_disassemble_inst(FILE *file, const struct gen_device_info *devinfo,
                format(file, ")");
                break;
             }
-            /* FALLTHROUGH */
          }
+         /* FALLTHROUGH */
 
          case GEN7_SFID_PIXEL_INTERPOLATOR:
             if (devinfo->gen >= 7) {



More information about the mesa-commit mailing list