Mesa (master): spirv: add missing fallthrough comments

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 3 00:33:04 UTC 2020


Module: Mesa
Branch: master
Commit: cb8cd64411316ca94ef1bb1f95374bbf405f13da
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cb8cd64411316ca94ef1bb1f95374bbf405f13da

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Wed Jul  1 15:55:47 2020 +1000

spirv: add missing fallthrough comments

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5705>

---

 src/compiler/spirv/vtn_subgroup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/compiler/spirv/vtn_subgroup.c b/src/compiler/spirv/vtn_subgroup.c
index 8d17845c1a0..e8c3db79b9d 100644
--- a/src/compiler/spirv/vtn_subgroup.c
+++ b/src/compiler/spirv/vtn_subgroup.c
@@ -88,7 +88,7 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp opcode,
       break;
    }
 
-   case SpvOpGroupNonUniformBallot: ++w;
+   case SpvOpGroupNonUniformBallot: ++w; /* fallthrough */
    case SpvOpSubgroupBallotKHR: {
       vtn_fail_if(val->type->type != glsl_vector_type(GLSL_TYPE_UINT, 4),
                   "OpGroupNonUniformBallot must return a uvec4");
@@ -177,14 +177,14 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp opcode,
       break;
    }
 
-   case SpvOpGroupNonUniformBroadcastFirst: ++w;
+   case SpvOpGroupNonUniformBroadcastFirst: ++w; /* fallthrough */
    case SpvOpSubgroupFirstInvocationKHR:
       vtn_build_subgroup_instr(b, nir_intrinsic_read_first_invocation,
                                val->ssa, vtn_ssa_value(b, w[3]), NULL, 0, 0);
       break;
 
    case SpvOpGroupNonUniformBroadcast:
-   case SpvOpGroupBroadcast: ++w;
+   case SpvOpGroupBroadcast: ++w; /* fallthrough */
    case SpvOpSubgroupReadInvocationKHR:
       vtn_build_subgroup_instr(b, nir_intrinsic_read_invocation,
                                val->ssa, vtn_ssa_value(b, w[3]),



More information about the mesa-commit mailing list