Mesa (master): vc4: Only call nir_lower_io on shader_in/out
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jul 6 20:19:16 UTC 2020
Module: Mesa
Branch: master
Commit: 96d99f2eccb4bea4b9ede38f9b2e472cdc617e99
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=96d99f2eccb4bea4b9ede38f9b2e472cdc617e99
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Jun 10 17:53:18 2020 -0500
vc4: Only call nir_lower_io on shader_in/out
Gallium drivers should never see nir_var_uniform because gallium lowers
regular uniforms to a UBO. No GL driver should ever see either
nir_var_mem_shared because that's lowered in GLSL IR.
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5418>
---
src/gallium/drivers/vc4/vc4_program.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/vc4/vc4_program.c b/src/gallium/drivers/vc4/vc4_program.c
index b06bd89963c..3ad81a05909 100644
--- a/src/gallium/drivers/vc4/vc4_program.c
+++ b/src/gallium/drivers/vc4/vc4_program.c
@@ -2470,8 +2470,8 @@ vc4_shader_state_create(struct pipe_context *pctx,
if (s->info.stage == MESA_SHADER_VERTEX)
NIR_PASS_V(s, nir_lower_point_size, 1.0f, 0.0f);
- NIR_PASS_V(s, nir_lower_io, nir_var_all, type_size,
- (nir_lower_io_options)0);
+ NIR_PASS_V(s, nir_lower_io, nir_var_shader_in | nir_var_shader_out,
+ type_size, (nir_lower_io_options)0);
NIR_PASS_V(s, nir_lower_regs_to_ssa);
NIR_PASS_V(s, nir_normalize_cubemap_coords);
More information about the mesa-commit
mailing list