Mesa (master): gallium/util: Fix location of the comment about S8_UINT handling.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 7 18:47:18 UTC 2020


Module: Mesa
Branch: master
Commit: 019a0309073b818b4dedbecf457813586b333332
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=019a0309073b818b4dedbecf457813586b333332

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Jul  1 16:17:32 2020 -0700

gallium/util: Fix location of the comment about S8_UINT handling.

I clearly wrote it in the wrong place in "softpipe: Refactor
pipe_get/put_tile_rgba_* paths."

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5728>

---

 src/gallium/auxiliary/util/u_tile.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_tile.c b/src/gallium/auxiliary/util/u_tile.c
index add92ed8139..daea31cfd56 100644
--- a/src/gallium/auxiliary/util/u_tile.c
+++ b/src/gallium/auxiliary/util/u_tile.c
@@ -365,10 +365,6 @@ pipe_put_tile_rgba(struct pipe_transfer *pt,
    if (u_clip_tile(x, y, &w, &h, &pt->box))
       return;
 
-   /* softpipe's S8_UINT texture cache fetch needs to take the rgba_format
-    * path, not ui (since there's no ui unpack for s8, but it's technically
-    * pure integer).
-    */
    if (util_format_is_pure_uint(format)) {
       util_format_write_4ui(format,
                             p, src_stride * sizeof(float),
@@ -435,6 +431,10 @@ pipe_get_tile_rgba(struct pipe_transfer *pt,
 
    pipe_get_tile_raw(pt, src, x, y, w, h, packed, 0);
 
+   /* softpipe's S8_UINT texture cache fetch needs to take the rgba_format
+    * path, not ui (since there's no ui unpack for s8, but it's technically
+    * pure integer).
+    */
    if (util_format_is_pure_uint(format) &&
        !util_format_is_depth_or_stencil(format)) {
       util_format_read_4ui(format,



More information about the mesa-commit mailing list