Mesa (master): glsl: remove the return type from lower_precision

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 8a93d2f128b3cf906069d616a3040d3182ff22c0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a93d2f128b3cf906069d616a3040d3182ff22c0

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Wed Jun 24 03:26:31 2020 -0400

glsl: remove the return type from lower_precision

It's unused.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5746>

---

 src/compiler/glsl/ir_optimization.h   |  2 +-
 src/compiler/glsl/lower_precision.cpp | 11 ++---------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/compiler/glsl/ir_optimization.h b/src/compiler/glsl/ir_optimization.h
index 0274ad260da..9f002e9b9e2 100644
--- a/src/compiler/glsl/ir_optimization.h
+++ b/src/compiler/glsl/ir_optimization.h
@@ -188,7 +188,7 @@ ir_variable *compare_index_block(ir_builder::ir_factory &body,
 bool lower_64bit_integer_instructions(exec_list *instructions,
                                       unsigned what_to_lower);
 
-bool lower_precision(const struct gl_shader_compiler_options *options,
+void lower_precision(const struct gl_shader_compiler_options *options,
                      exec_list *instructions);
 
 #endif /* GLSL_IR_OPTIMIZATION_H */
diff --git a/src/compiler/glsl/lower_precision.cpp b/src/compiler/glsl/lower_precision.cpp
index 03f9089444d..13ba6e0d47f 100644
--- a/src/compiler/glsl/lower_precision.cpp
+++ b/src/compiler/glsl/lower_precision.cpp
@@ -49,8 +49,6 @@ public:
 
    ir_function_signature *map_builtin(ir_function_signature *sig);
 
-   bool progress;
-
    /* Set of rvalues that can be lowered. This will be filled in by
     * find_lowerable_rvalues_visitor. Only the root node of a lowerable section
     * will be added to this set.
@@ -777,8 +775,6 @@ find_precision_visitor::handle_rvalue(ir_rvalue **rvalue)
     */
    if ((*rvalue)->type->base_type != GLSL_TYPE_BOOL)
       *rvalue = convert_precision((*rvalue)->type->base_type, true, *rvalue);
-
-   progress = true;
 }
 
 ir_visitor_status
@@ -847,8 +843,7 @@ find_precision_visitor::map_builtin(ir_function_signature *sig)
 }
 
 find_precision_visitor::find_precision_visitor(const struct gl_shader_compiler_options *options)
-   : progress(false),
-     lowerable_rvalues(_mesa_pointer_set_create(NULL)),
+   : lowerable_rvalues(_mesa_pointer_set_create(NULL)),
      lowered_builtins(NULL),
      clone_ht(NULL),
      lowered_builtin_mem_ctx(NULL),
@@ -869,7 +864,7 @@ find_precision_visitor::~find_precision_visitor()
 
 }
 
-bool
+void
 lower_precision(const struct gl_shader_compiler_options *options,
                 exec_list *instructions)
 {
@@ -878,6 +873,4 @@ lower_precision(const struct gl_shader_compiler_options *options,
    find_lowerable_rvalues(options, instructions, v.lowerable_rvalues);
 
    visit_list_elements(&v, instructions);
-
-   return v.progress;
 }