Mesa (master): panfrost: add some missing fallthrough comments

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 8 03:41:53 UTC 2020


Module: Mesa
Branch: master
Commit: f35283d32e35cdda709084b844c713f7707f83d0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f35283d32e35cdda709084b844c713f7707f83d0

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Mon Jul  6 13:44:56 2020 +1000

panfrost: add some missing fallthrough comments

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5766>

---

 src/panfrost/bifrost/disassemble.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/panfrost/bifrost/disassemble.c b/src/panfrost/bifrost/disassemble.c
index c3b7fe6c413..92fbf20a17f 100644
--- a/src/panfrost/bifrost/disassemble.c
+++ b/src/panfrost/bifrost/disassemble.c
@@ -1592,6 +1592,7 @@ static void dump_add(FILE *fp, uint64_t word, struct bifrost_regs regs,
         }
         case ADD_LOAD_ATTR:
                 fprintf(fp, "location:%d, ", (ADD.op >> 3) & 0x1f);
+                /* fallthrough */
         case ADD_TWO_SRC:
                 dump_src(fp, ADD.src0, regs, consts, false);
                 fprintf(fp, ", ");
@@ -1987,6 +1988,7 @@ bool dump_clause(FILE *fp, uint32_t *words, unsigned *size, unsigned offset, boo
                                 // only constants can come after this
                                 num_instrs = 1;
                                 done = stop;
+                                /* fallthrough */
                         case 0x5:
                                 header_bits = bits(words[2], 19, 32) | ((uint64_t) words[3] << (32 - 19));
                                 main_instr.add_bits |= (tag & 0x7) << 17;



More information about the mesa-commit mailing list