Mesa (master): spirv: Also copy over binding information for atomic counters

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 24 18:35:59 UTC 2020


Module: Mesa
Branch: master
Commit: 63cf8adb12440512226dddbe3e233bcba87c7c18
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=63cf8adb12440512226dddbe3e233bcba87c7c18

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Fri Jul 24 10:04:48 2020 -0500

spirv: Also copy over binding information for atomic counters

I missed this if statement so atomic counters weren't getting bindings
and, when you have more than one of them, that meant they were all
getting combined into one.

Fixes: 3584cb09bc15 "spirv: Give atomic counters their own variable mode"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6060>

---

 src/compiler/spirv/vtn_variables.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c
index e4013e940ac..2100b481cce 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -2341,7 +2341,8 @@ vtn_create_variable(struct vtn_builder *b, struct vtn_value *val,
 
    if (var->mode == vtn_variable_mode_uniform ||
        var->mode == vtn_variable_mode_ubo ||
-       var->mode == vtn_variable_mode_ssbo) {
+       var->mode == vtn_variable_mode_ssbo ||
+       var->mode == vtn_variable_mode_atomic_counter) {
       /* XXX: We still need the binding information in the nir_variable
        * for these. We should fix that.
        */



More information about the mesa-commit mailing list