Mesa (master): aco: enable value numbering of s_buffer_load_*

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 28 17:17:22 UTC 2020


Module: Mesa
Branch: master
Commit: 46c4b256239b12eb808a3c4df2ec625c3dd90e76
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=46c4b256239b12eb808a3c4df2ec625c3dd90e76

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Mon Jun 29 13:22:19 2020 +0100

aco: enable value numbering of s_buffer_load_*

fossil-db (Navi):
Totals from 33 (0.03% of 114665) affected shaders:
SGPRs: 2176 -> 2152 (-1.10%)
VGPRs: 1572 -> 1564 (-0.51%)
CodeSize: 115988 -> 115472 (-0.44%)
Instrs: 21459 -> 21385 (-0.34%)

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4905>

---

 src/amd/compiler/aco_opt_value_numbering.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/amd/compiler/aco_opt_value_numbering.cpp b/src/amd/compiler/aco_opt_value_numbering.cpp
index de3d894bf54..ede60f4775e 100644
--- a/src/amd/compiler/aco_opt_value_numbering.cpp
+++ b/src/amd/compiler/aco_opt_value_numbering.cpp
@@ -224,8 +224,6 @@ struct InstrPred {
             return aK->imm == bK->imm;
          }
          case Format::SMEM: {
-            if (!a->operands.empty() && a->operands[0].bytes() == 16)
-               return false;
             SMEM_instruction* aS = static_cast<SMEM_instruction*>(a);
             SMEM_instruction* bS = static_cast<SMEM_instruction*>(b);
             /* isel shouldn't be creating situations where this assertion fails */



More information about the mesa-commit mailing list