Mesa (master): intel/tools: Simplify dstregion

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 31 20:40:48 UTC 2020


Module: Mesa
Branch: master
Commit: 363e5ef5a5d43c0c59dbbdb3740f6bcadfb95a89
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=363e5ef5a5d43c0c59dbbdb3740f6bcadfb95a89

Author: Matt Turner <mattst88 at gmail.com>
Date:   Wed Jul 15 16:32:37 2020 -0700

intel/tools: Simplify dstregion

Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5956>

---

 src/intel/tools/i965_gram.y | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/src/intel/tools/i965_gram.y b/src/intel/tools/i965_gram.y
index bddf9781ed9..03ebc7e3e6d 100644
--- a/src/intel/tools/i965_gram.y
+++ b/src/intel/tools/i965_gram.y
@@ -1426,14 +1426,9 @@ dstoperand:
 	dstreg dstregion writemask reg_type
 	{
 		$$ = $1;
-
-		if ($2 == -1) {
-			$$.hstride = BRW_HORIZONTAL_STRIDE_1;
-			$$.vstride = BRW_VERTICAL_STRIDE_1;
-			$$.width = BRW_WIDTH_1;
-		} else {
-			$$.hstride = $2;
-		}
+		$$.vstride = BRW_VERTICAL_STRIDE_1;
+		$$.width = BRW_WIDTH_1;
+		$$.hstride = $2;
 		$$.type = $4;
 		$$.writemask = $3;
 		$$.swizzle = BRW_SWIZZLE_NOOP;
@@ -1457,13 +1452,9 @@ dstoperandex:
 	| nullreg dstregion writemask reg_type
 	{
 		$$ = $1;
-		if ($2 == -1) {
-			$$.hstride = BRW_HORIZONTAL_STRIDE_1;
-			$$.vstride = BRW_VERTICAL_STRIDE_1;
-			$$.width = BRW_WIDTH_1;
-		} else {
-			$$.hstride = $2;
-		}
+		$$.vstride = BRW_VERTICAL_STRIDE_1;
+		$$.width = BRW_WIDTH_1;
+		$$.hstride = $2;
 		$$.writemask = $3;
 		$$.type = $4;
 	}
@@ -1926,7 +1917,10 @@ immval:
 
 /* Regions */
 dstregion:
-	%empty 	{ $$ = -1; }
+	%empty
+	{
+		$$ = BRW_HORIZONTAL_STRIDE_1;
+	}
 	| LANGLE exp RANGLE
 	{
 		if ($2 != 0 && ($2 > 4 || !isPowerofTwo($2)))



More information about the mesa-commit mailing list