Mesa (master): radeonsi: remove const_buffers_declared hacks

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jun 2 21:11:21 UTC 2020


Module: Mesa
Branch: master
Commit: 877c56bfdcb97e47453b86f23a13033438f0daa1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=877c56bfdcb97e47453b86f23a13033438f0daa1

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Thu May 21 04:18:19 2020 -0400

radeonsi: remove const_buffers_declared hacks

This was a bug that was uncovered by 4553fc66a5f23607c2e872d8ac8755c747bd0bd2.

Piglit: spec at arb_uniform_buffer_object@maxblocks

Fixes: 4553fc66a5f23607c2e872d8ac8755c747bd0bd2

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5209>

---

 src/gallium/drivers/radeonsi/si_shader_nir.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c
index 03b04ba0293..74aa9f475f3 100644
--- a/src/gallium/drivers/radeonsi/si_shader_nir.c
+++ b/src/gallium/drivers/radeonsi/si_shader_nir.c
@@ -714,9 +714,7 @@ void si_nir_scan_shader(const struct nir_shader *nir, struct si_shader_info *inf
 
    info->constbuf0_num_slots = nir->num_uniforms;
    info->shader_buffers_declared = u_bit_consecutive(0, nir->info.num_ssbos);
-   info->const_buffers_declared = u_bit_consecutive(1, nir->info.num_ubos);
-   if (nir->num_uniforms > 0)
-      info->const_buffers_declared |= 1;
+   info->const_buffers_declared = u_bit_consecutive(0, nir->info.num_ubos);
    info->images_declared = u_bit_consecutive(0, nir->info.num_images);
    info->msaa_images_declared = nir->info.msaa_images;
    info->samplers_declared = nir->info.textures_used;



More information about the mesa-commit mailing list