Mesa (master): aco: Don't std::move temporary object.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Jun 2 21:44:39 UTC 2020
Module: Mesa
Branch: master
Commit: 7b1bc460fd6ae9bf5efeca62227bb05e0c50ee15
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b1bc460fd6ae9bf5efeca62227bb05e0c50ee15
Author: Oschowa <oschowa at web.de>
Date: Fri May 22 12:52:05 2020 +0200
aco: Don't std::move temporary object.
Fixes the following clang warning:
mesa/src/amd/compiler/aco_optimizer.cpp:2928:15: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
ctx.uses = std::move(dead_code_analysis(program));
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5228>
---
src/amd/compiler/aco_optimizer.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index c6228691b36..f16f165c21b 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -2929,7 +2929,7 @@ void optimize(Program* program)
label_instruction(ctx, block, instr);
}
- ctx.uses = std::move(dead_code_analysis(program));
+ ctx.uses = dead_code_analysis(program);
/* 2. Combine v_mad, omod, clamp and propagate sgpr on VALU instructions */
for (Block& block : program->blocks) {
More information about the mesa-commit
mailing list