Mesa (master): vdpau: Fix wrong calloc sizeof argument.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 4 00:16:13 UTC 2020


Module: Mesa
Branch: master
Commit: 8b353524b04fa9cd77e21e2d036c69f1cff30c35
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8b353524b04fa9cd77e21e2d036c69f1cff30c35

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri May 22 17:59:27 2020 -0700

vdpau: Fix wrong calloc sizeof argument.

Fix warning reported by Coverity Scan.

Wrong sizeof argument (SIZEOF_MISMATCH)
suspicious_sizeof: Passing argument 3544UL (sizeof
(vlVdpPresentationQueue)) to function calloc that returns a pointer of
type vlVdpPresentationQueueTarget * is suspicious because a multiple of
sizeof (vlVdpPresentationQueueTarget) /*16*/ is expected.

Fixes: 65fe0866aec7 ("vl: implemented a few functions and made stubs to get mplayer running")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3026
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5182>

---

 src/gallium/frontends/vdpau/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/frontends/vdpau/device.c b/src/gallium/frontends/vdpau/device.c
index 5df30ea3c08..f69c54c4536 100644
--- a/src/gallium/frontends/vdpau/device.c
+++ b/src/gallium/frontends/vdpau/device.c
@@ -170,7 +170,7 @@ vlVdpPresentationQueueTargetCreateX11(VdpDevice device, Drawable drawable,
    if (!dev)
       return VDP_STATUS_INVALID_HANDLE;
 
-   pqt = CALLOC(1, sizeof(vlVdpPresentationQueue));
+   pqt = CALLOC(1, sizeof(vlVdpPresentationQueueTarget));
    if (!pqt)
       return VDP_STATUS_RESOURCES;
 



More information about the mesa-commit mailing list