Mesa (master): radv/aco: enable VK_KHR_shader_subgroup_extended_types on GFX6-GFX7

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jun 5 14:30:23 UTC 2020


Module: Mesa
Branch: master
Commit: bfff330f061ff8789d7d26f164725af91cfd2c74
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfff330f061ff8789d7d26f164725af91cfd2c74

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Jun  4 10:41:50 2020 +0200

radv/aco: enable VK_KHR_shader_subgroup_extended_types on GFX6-GFX7

CTS pass on Pitcairn (GFX6). This extension isn't really useful
without 8-bit/16-bit storage though but this is going to be exposed
soon.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5327>

---

 src/amd/vulkan/radv_device.c      | 2 +-
 src/amd/vulkan/radv_extensions.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 36fee0672f1..9c5c6f90ed5 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1012,7 +1012,7 @@ radv_get_physical_device_features_1_2(struct radv_physical_device *pdevice,
 	f->scalarBlockLayout = pdevice->rad_info.chip_class >= GFX7;
 	f->imagelessFramebuffer = true;
 	f->uniformBufferStandardLayout = true;
-	f->shaderSubgroupExtendedTypes = !pdevice->use_aco || pdevice->rad_info.chip_class >= GFX8;
+	f->shaderSubgroupExtendedTypes = true;
 	f->separateDepthStencilLayouts = true;
 	f->hostQueryReset = true;
 	f->timelineSemaphore = pdevice->rad_info.has_syncobj_wait_for_submit;
diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
index fe9c9655625..7db4aa39907 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -100,7 +100,7 @@ EXTENSIONS = [
     Extension('VK_KHR_shader_float_controls',             1, True),
     Extension('VK_KHR_shader_float16_int8',               1, '!device->use_aco || device->rad_info.chip_class >= GFX8'),
     Extension('VK_KHR_shader_non_semantic_info',          1, True),
-    Extension('VK_KHR_shader_subgroup_extended_types',    1, '!device->use_aco || device->rad_info.chip_class >= GFX8'),
+    Extension('VK_KHR_shader_subgroup_extended_types',    1, True),
     Extension('VK_KHR_spirv_1_4',                         1, True),
     Extension('VK_KHR_storage_buffer_storage_class',      1, True),
     Extension('VK_KHR_surface',                          25, 'RADV_HAS_SURFACE'),



More information about the mesa-commit mailing list