Mesa (master): etnaviv: drop translate_blend(..)
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jun 8 15:48:34 UTC 2020
Module: Mesa
Branch: master
Commit: 7ec25820875ff1da0c2f5dab60cf5dda9eb51d30
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ec25820875ff1da0c2f5dab60cf5dda9eb51d30
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date: Sat Jun 6 12:28:13 2020 +0200
etnaviv: drop translate_blend(..)
PIPE_BLEND_* matches 1:1 the hardware defines.
Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4187>
---
src/gallium/drivers/etnaviv/etnaviv_blend.c | 11 +++++++++--
src/gallium/drivers/etnaviv/etnaviv_translate.h | 20 --------------------
2 files changed, 9 insertions(+), 22 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_blend.c b/src/gallium/drivers/etnaviv/etnaviv_blend.c
index b9a7c0373d5..644409a437e 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_blend.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_blend.c
@@ -43,6 +43,13 @@ etna_blend_state_create(struct pipe_context *pctx,
struct etna_blend_state *co = CALLOC_STRUCT(etna_blend_state);
bool alpha_enable, logicop_enable;
+ /* pipe_blend_func happens to match the hardware. */
+ STATIC_ASSERT(PIPE_BLEND_ADD == BLEND_EQ_ADD);
+ STATIC_ASSERT(PIPE_BLEND_SUBTRACT == BLEND_EQ_SUBTRACT);
+ STATIC_ASSERT(PIPE_BLEND_REVERSE_SUBTRACT == BLEND_EQ_REVERSE_SUBTRACT);
+ STATIC_ASSERT(PIPE_BLEND_MIN == BLEND_EQ_MIN);
+ STATIC_ASSERT(PIPE_BLEND_MAX == BLEND_EQ_MAX);
+
if (!co)
return NULL;
@@ -79,8 +86,8 @@ etna_blend_state_create(struct pipe_context *pctx,
VIVS_PE_ALPHA_CONFIG_SRC_FUNC_ALPHA(translate_blend_factor(rt0->alpha_src_factor)) |
VIVS_PE_ALPHA_CONFIG_DST_FUNC_COLOR(translate_blend_factor(rt0->rgb_dst_factor)) |
VIVS_PE_ALPHA_CONFIG_DST_FUNC_ALPHA(translate_blend_factor(rt0->alpha_dst_factor)) |
- VIVS_PE_ALPHA_CONFIG_EQ_COLOR(translate_blend(rt0->rgb_func)) |
- VIVS_PE_ALPHA_CONFIG_EQ_ALPHA(translate_blend(rt0->alpha_func));
+ VIVS_PE_ALPHA_CONFIG_EQ_COLOR(rt0->rgb_func) |
+ VIVS_PE_ALPHA_CONFIG_EQ_ALPHA(rt0->alpha_func);
} else {
co->PE_ALPHA_CONFIG = 0;
}
diff --git a/src/gallium/drivers/etnaviv/etnaviv_translate.h b/src/gallium/drivers/etnaviv/etnaviv_translate.h
index 0638bfd5dca..758a682d084 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_translate.h
+++ b/src/gallium/drivers/etnaviv/etnaviv_translate.h
@@ -113,26 +113,6 @@ translate_stencil_op(unsigned stencil_op)
}
}
-static inline uint32_t
-translate_blend(unsigned blend)
-{
- switch (blend) {
- case PIPE_BLEND_ADD:
- return BLEND_EQ_ADD;
- case PIPE_BLEND_SUBTRACT:
- return BLEND_EQ_SUBTRACT;
- case PIPE_BLEND_REVERSE_SUBTRACT:
- return BLEND_EQ_REVERSE_SUBTRACT;
- case PIPE_BLEND_MIN:
- return BLEND_EQ_MIN;
- case PIPE_BLEND_MAX:
- return BLEND_EQ_MAX;
- default:
- DBG("Unhandled blend: %i", blend);
- return ETNA_NO_MATCH;
- }
-}
-
static inline uint32_t
translate_blend_factor(unsigned blend_factor)
{
More information about the mesa-commit
mailing list